Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

enhance: AppLogEndpoint + AppLogSecret on Region object supporting the new app logs feature #2474

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

iwilltry42
Copy link
Contributor

@iwilltry42 iwilltry42 commented Feb 5, 2024

Tracking Issue https://github.com/acorn-io/manager/issues/1962

This information will be used by the Account API Server to determine where to get the app logs from for this region.
At some point we will have multiple endpoints per geographical region.
Which one to use will be determined dynamically.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Summary by CodeRabbit

  • New Features
    • Enhanced regional settings to include application log endpoint and secret configurations.

…w app logs feature

Signed-off-by: Thorsten Klein <tk@thklein.io>
Copy link

coderabbitai bot commented Feb 5, 2024

Walkthrough

This update introduces two new fields, AppLogEndpoint and AppLogSecret, to the RegionStatus struct within the region.go file. These additions are aimed at enhancing log management capabilities by specifying an endpoint for application logs and a secret for secure access.

Changes

File Path Change Summary
pkg/apis/api.acorn.io/v1/region.go Added AppLogEndpoint and AppLogSecret fields to RegionStatus struct.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 92d24ac and 1b8d865.
Files ignored due to path filters (1)
  • pkg/openapi/generated/openapi_generated.go is excluded by: !**/generated/**
Files selected for processing (1)
  • pkg/apis/api.acorn.io/v1/region.go (1 hunks)
Additional comments: 1
pkg/apis/api.acorn.io/v1/region.go (1)
  • 32-33: Ensure that AppLogSecret is handled securely throughout the system, considering encryption at rest and access control during runtime.

@iwilltry42 iwilltry42 merged commit 3103a5e into acorn-io:main Feb 5, 2024
4 checks passed
@iwilltry42 iwilltry42 deleted the feat/logging branch February 5, 2024 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants