Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing "export const base" in walk.d.ts #1044

Merged
merged 2 commits into from
Jun 7, 2021
Merged

add missing "export const base" in walk.d.ts #1044

merged 2 commits into from
Jun 7, 2021

Conversation

Nauja
Copy link
Contributor

@Nauja Nauja commented Jun 4, 2021

Just added at the end:

   export const findNodeAfter: typeof findNodeAround;
+  export const base: object;
}

fix 1043

@Nauja
Update walk.d.ts
c9b3802 
add missing "export const base"
@marijnh
Copy link
Member

marijnh commented Jun 6, 2021

Thanks. Wouldn't RecursiveVisitors<any> be a better type for this variable?

@Nauja
Copy link
Contributor Author

Nauja commented Jun 6, 2021

Should be indeed, I didn't see this type. I changed it

@marijnh marijnh merged commit ddfd5e3 into acornjs:master Jun 7, 2021
@marijnh
Copy link
Member

marijnh commented Jun 7, 2021

Thanks!

@harelmo
Copy link

harelmo commented Jun 28, 2021

Hi guys, any ETA for publishing this change to the latest version of acorn-walk? 🙏

@marijnh
Copy link
Member

marijnh commented Jun 29, 2021

I've tagged 8.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing "export const base" in walk.d.ts
3 participants
@Nauja @marijnh @harelmo