Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Zig 0.14 #49

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Upgrade to Zig 0.14 #49

merged 3 commits into from
Mar 10, 2025

Conversation

lalinsky
Copy link
Member

No description provided.

Copy link

coderabbitai bot commented Mar 10, 2025

Walkthrough

This pull request updates project configuration, including the project name, minimum Zig version, and fingerprint in the build configuration. It also modifies various internal comparison functions by renaming and introducing new ordering methods. Several modules have revised sorting and comparison operations, while changes to type usage are evident in the main and file output functions. Additionally, server error handling and configuration have been adjusted, and there is a minor modification in the reference counter decrement logic.

Changes

File(s) Change Summary
build.zig.zon Updated project metadata: project name changed from literal ("fpindex") to reference (.fpindex), minimum Zig version increased from "0.13.0" to "0.14.0", added .fingerprint, and dependency URLs/commit hashes updated to master branch references.
src/FileSegment.zig, src/MemorySegment.zig, src/Oplog.zig, src/segment.zig, src/segment_merger.zig Revised comparison and sorting functions: updated memory alignment (from std.mem.page_size to std.heap.page_size_min in FileSegment), added compareHashes, renamed cmp to lessThan, removed cmpByHash in favor of new methods (order/orderByHash), and adjusted sort calls (e.g., lowerBound, equalRange, and PDQ sort) accordingly.
src/main.zig, src/filefmt.zig Modified explicit type usage: changed std_options from an anonymous struct to std.Options in main and removed explicit structure type references in packer.write calls in filefmt.
src/server.zig Added public functions notFound and uncaughtError in Context; changed Server type from httpz.ServerApp(*Context) to httpz.Server(*Context); updated installSignalHandlers to return void; and adjusted route handler calls and msgpack serialization calls by removing explicit type parameters.
src/utils/shared_ptr.zig Updated reference counter decrement logic: replaced the memory fence call with a load call (self.refs.load(.acquire)) in the decr method.
src/index_tests.zig, src/segment_merge_policy.zig Updated random number generation: changed PRNG initialization from std.rand to std.Random and adjusted random integer generation calls accordingly.
.github/workflows/build-legacy-proxy.yml Removed step using actions/setup-python@v5 for Python setup in the GitHub Actions workflow.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0c138 and a0da019.

📒 Files selected for processing (1)
  • .github/workflows/build-legacy-proxy.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/build-legacy-proxy.yml

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lalinsky lalinsky merged commit 80ebd63 into main Mar 10, 2025
5 checks passed
@lalinsky lalinsky deleted the zig-0.14 branch March 10, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant