Making security test failure more verbose.

acquia · Jul 19, 2016 · a73b5c1 · a73b5c1
1 parent 13ac1e6
commit a73b5c1
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/template/build/core/phing/tasks/tests.xml b/template/build/core/phing/tasks/tests.xml
@@ -132,13 +132,21 @@
   </target>
 
   <!-- Ensure Drupal doesn't have any modules requiring security updates. -->
-  <!-- Intentionally removed checkreturn="true" so that this does not cause failure. -->
   <target name="tests:security-updates"
           description="Check local Drupal installation for security updates.">
     <exec dir="${docroot}"
           command="! ${drush.cmd} -n ups --check-disabled --security-only 2>/dev/null | grep 'SECURITY UPDATE'"
           checkreturn="true"
           logoutput="true"
+          returnProperty="securityPass"
           passthru="true"/>
+
+    <!-- Output message on failure. -->
+    <if>
+      <not><equals arg1="${securityPass}" arg2="0"/></not>
+      <then>
+        <echo>One or more of your dependency has an outstanding security update. Please apply update(s) immediately. Failing build.</echo>
+      </then>
+    </if>
   </target>
 </project>