Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run drush updb with the entity-updates flag during setup:config-import, it's dangerous #1014

Closed
bkosborne opened this issue Jan 26, 2017 · 0 comments
Assignees
Labels
Enhancement A feature or feature request

Comments

@bkosborne
Copy link
Contributor

When BLT executes the setup:config-import task, it will run drush updb after importing configuration. It passes the --entity-updates flag to the updb.

I think this should be removed.

This stack overflow answer indicates that it's really a development tool and shouldn't be run under normal circumstances.

There's also a detailed change record regarding the removal of the automated entity updates system from update.php and explains why the automated update system is dangerous and shouldn't be used normally. Basically modules should handle the entity updates themselves in update hooks.

Here's an additional change record that explains the user-facing changes of the removal of the automated system.

Given that BLT's acquia cloud hooks will run the setup:config-import task during deploys, it seems dangerous to include the --entity-updates flag in the updb command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants