Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer merge + composer patches not playing nicely #1292

Closed
arknoll opened this issue Apr 3, 2017 · 0 comments
Closed

composer merge + composer patches not playing nicely #1292

arknoll opened this issue Apr 3, 2017 · 0 comments
Assignees
Labels
Bug Something isn't working

Comments

@arknoll
Copy link
Contributor

arknoll commented Apr 3, 2017

My system information:

  • Operating system type: Mac OSX
  • Operating system version: Sierra
  • BLT version: 8.7.0-beta2

When I run this command on a freshly cloned codebase that includes Lightning as a dependency:

composer install

And I expected this to happen:
Lightning's composer patches to be applied

What actually happens:
They are not applied

See https://github.com/acquia-pso/canary/pull/32#issuecomment-291192345

Example:
See this patch in lightning profile as an example:

"1356276 - Allow profiles to provide a base/parent profile and load them in the correct order":
                "https://www.drupal.org/files/issues/1356276-276-8.2.x.patch"

It includes this change:

--- a/core/core.services.yml
+++ b/core/core.services.yml
@@ -298,7 +298,7 @@ services:
       - { name: event_subscriber }
   config.installer:
     class: Drupal\Core\Config\ConfigInstaller
-    arguments: ['@config.factory', '@config.storage', '@config.typed', '@config.manager', '@event_dispatcher']
+    arguments: ['@config.factory', '@config.storage', '@config.typed', '@config.manager', '@event_dispatcher', '@profile_handler']
     lazy: true
   config.storage:
     class: Drupal\Core\Config\CachedStorage

My codebase after a composer install:
core/core.services.yml

  config.installer:
    class: Drupal\Core\Config\ConfigInstaller
    arguments: ['@config.factory', '@config.storage', '@config.typed', '@config.manager', '@event_dispatcher']
    lazy: true

The patches aren't getting applied correctly.

@grasmash grasmash added the Bug Something isn't working label Apr 3, 2017
@grasmash grasmash self-assigned this Apr 3, 2017
grasmash added a commit that referenced this issue Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants