Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable security-updates #1440

Closed
leonk opened this issue Apr 26, 2017 · 4 comments
Closed

Cannot disable security-updates #1440

leonk opened this issue Apr 26, 2017 · 4 comments
Assignees
Labels
Bug Something isn't working

Comments

@leonk
Copy link
Contributor

leonk commented Apr 26, 2017

My system information:

  • Operating system type: OS X
  • Operating system version: 10.12.3
  • BLT version: 8.8.3

Output of blt doctor:

blt doctor
.
[disabletargets] Cannot disable target tests:security-updates, it does not exist.
blt > doctor:
Changed current directory to /Users/leonkessler/.composer
+----------------------+----------------------------------------------------------------------------------+
| Property             | Value                                                                            |
+----------------------+----------------------------------------------------------------------------------+
| %paths               |                                                                                  |
|  - %root             | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot                 |
|  - %site             | sites/default                                                                    |
|  - %modules          | modules                                                                          |
|  - %themes           | themes                                                                           |
|  - %config-sync      | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/config/default          |
| blt-version          | 8.8.3                                                                            |
| config-sync          | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/config/default          |
| db-driver            | mysql                                                                            |
| db-hostname          | localhost                                                                        |
| db-name              | drupal                                                                           |
| db-password          | drupal                                                                           |
| db-port              | 3306                                                                             |
| db-username          | drupal                                                                           |
| drupal-settings-file | sites/default/settings.php                                                       |
| drupal-version       | 8.3.1                                                                            |
| drush-alias-files    | /Users/leonkessler/.drush/drupal8-drupalvm.aliases.drushrc.php                   |
|                      | /Users/leonkessler/.drush/drupal8.aliases.drushrc.php                            |
|                      | /Users/leonkessler/.drush/drupalvm.aliases.drushrc.php                           |
|                      | /Users/leonkessler/.drush/EduTrain.aliases.drushrc.php                           |
|                      | /Users/leonkessler/.drush/fluxus-site-platform.aliases.drushrc.php               |
|                      | /Users/leonkessler/.drush/glasshouse.aliases.drushrc.php                         |
|                      | /Users/leonkessler/.drush/pocuniper.aliases.drushrc.php                          |
|                      | /Users/leonkessler/.drush/rawpixel-preview.aliases.drushrc.php                   |
|                      | /Users/leonkessler/.drush/rawpixel.aliases.drushrc.php                           |
|                      | /Users/leonkessler/.drush/supapass.aliases.drushrc.php                           |
|                      | /Users/leonkessler/.drush/tes.aliases.drushrc.php                                |
|                      | /Users/leonkessler/.drush/the.aliases.drushrc.php                                |
|                      | /Users/leonkessler/.drush/uniper-drupalvm.aliases.drushrc.php                    |
|                      | /Users/leonkessler/.drush/uniper.aliases.drushrc.php                             |
|                      | /Users/leonkessler/.drush/vandemoortele.aliases.drushrc.php                      |
|                      | /Users/leonkessler/.drush/wateraid-drupalvm.aliases.drushrc.php                  |
|                      | /Users/leonkessler/.drush/wateraidglobal.aliases.drushrc.php                     |
|                      | /Users/leonkessler/.drush/wateraidsites.aliases.drushrc.php                      |
|                      | /Users/leonkessler/.drush/yubl-moderation.aliases.drushrc.php                    |
|                      | /Users/leonkessler/.drush/yubl.aliases.drushrc.php                               |
|                      | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot/../drush/site-a |
|                      | liases/aliases.drushrc.php                                                       |
|                      | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot/../drush/site-a |
|                      | liases/example.acsf.aliases.drushrc.php                                          |
|                      | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot/../drush/site-a |
|                      | liases/example.local.aliases.drushrc.php                                         |
|                      | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot/../drush/site-a |
|                      | liases/wateraidglobal.acsf.aliases.drushrc.php                                   |
| drush-conf           | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/drush/drushrc.php       |
| drush-script         | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/vendor/drush/drush/drus |
|                      | h.php                                                                            |
| drush-temp           | /tmp                                                                             |
| drush-version        | 8.1.10                                                                           |
| local-drushrc        | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot/sites/default/l |
|                      | ocal.drushrc.php                                                                 |
| local-settings       | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot/sites/default/s |
|                      | ettings/local.settings.php                                                       |
| modules              | modules                                                                          |
| php-bin              | /usr/local/bin/php                                                               |
| php-conf             | /usr/local/etc/php/5.6/php.ini                                                   |
| php-os               | Darwin                                                                           |
| root                 | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot                 |
| site                 | sites/default                                                                    |
| themes               | themes                                                                           |
| uri                  | default                                                                          |
+----------------------+----------------------------------------------------------------------------------+
+--------------------------+----------------------------------------------------------------------------------+
| Check                    | Outcome                                                                          |
+--------------------------+----------------------------------------------------------------------------------+
| checkDocrootExists       | Found docroot.                                                                   |
| checkCoreExists          | Drupal core exists                                                               |
| checkSettingsFile        | BLT settings are included in settings file.                                      |
| checkLocalSettingsFile   | Found your local settings file.                                                  |
| checkLocalDrushFile      | Found your local drush settings file.                                            |
| checkUri                 | Site URI is not set                                                              |
|                          |                                                                                  |
|                          | Is $options['uri'] set correctly in                                              |
|                          | /Users/leonkessler/Sites/mirum/wateraidglobal-blt-switch/docroot/sites/default/l |
|                          | ocal.drushrc.php?                                                                |
|                          |                                                                                  |
| checkFileSystem:%files   | Public files directory is not set.                                               |
| checkFileSystem:%private | Private files directory is not set.                                              |
| checkFileSystem:%temp    | Temporary files directory is not set.                                            |
| checkDbConnection        | Could not connect to MySQL database.                                             |
|                          |                                                                                  |
|                          | Is your *AMP stack running?                                                      |
|                          | Are your database credentials correct?                                           |
|                          |   db-driver: mysql                                                               |
|                          |   db-hostname: localhost                                                         |
|                          |   db-username: drupal                                                            |
|                          |   db-password: drupal                                                            |
|                          |   db-name: drupal                                                                |
|                          |   db-port: 3306                                                                  |
|                          |                                                                                  |
|                          | To verify your mysql credentials, run `mysql -u drupal -h localhost -pdrupal -P  |
|                          | 3306`                                                                            |
|                          |                                                                                  |
|                          | Are you using the correct PHP binary?                                            |
|                          | Is PHP using the correct MySQL socket?                                           |
|                          |   php-os: Darwin                                                                 |
|                          |   php-bin: /usr/local/bin/php                                                    |
|                          |   php-conf: Array                                                                |
|                          |   php-mysql:                                                                     |
|                          |                                                                                  |
|                          | Are you using the correct site and settings.php file?                            |
|                          |   site: sites/default                                                            |
|                          |   drupal-settings-file: sites/default/settings.php                               |
|                          |                                                                                  |
|                          | To verify, run `drush sqlc`                                                      |
|                          |                                                                                  |
| checkDrupalBootstrapped  | Could not bootstrap Drupal via drush without alias.                              |
| checkCaching:page        | Drupal cache is disabled.                                                        |
| checkCaching:css         | CSS preprocessing is disabled.                                                   |
| checkCaching:js          | JS preprocessing is disabled.                                                    |
| checkNvmExists           | NVM exists.                                                                      |
| checkCiConfig            | Git remotes are set in project.yml.                                              |
| checkComposer:require    | acquia/blt is in composer.json's require object.                                 |
| checkComposer:plugins    | hirak/prestissimo plugin for composer is not installed.                          |
|                          |   Run `composer global require hirak/prestissimo:^0.3` to install it.            |
|                          |   This will improve composer install/update performance by parallelizing the     |
|                          | download of dependency information.                                              |
| checkBehat:exists        | Behat local settings file exists.                                                |
| checkBehat:uri           | base_url in tests/behat/local.yml does not match the site URI.                   |
|                          |   Behat base_url is set to "http://local.wateraidglobal.com".                    |
|                          |   Drush site URI is set to default.                                              |
| checkProjectYml:keys     | project.yml has no deprecated keys.                                              |
| checkAcsfConfig          | BLT settings are included in your pre-settings-php include.                      |
| checkPhpDateTimezone     | PHP setting for date.timezone is correctly set                                   |
+--------------------------+----------------------------------------------------------------------------------+

When I run this command:

blt whatever

I get the following output:

[disabletargets] Cannot disable target tests:security-updates, it does not exist.

And I expected this to happen: I want to disable the security-updates check.

Here's what's in my project.yml:

disable-targets:
  validate:
    phpcs: true
  tests:
    security-updates: true
@grasmash grasmash added the Bug Something isn't working label Apr 26, 2017
@grasmash
Copy link
Contributor

Hm, I'm not able to reproduce this on BLT 8.8.3. I added this to project.yml:

disable-targets:
  tests:
    security-updates: true

Then ran blt tests:security-updates. The output was:

The tests:security-updates command has been disabled. Skipping execution.

@grasmash grasmash added Support A support request and removed Bug Something isn't working labels Apr 26, 2017
@grasmash
Copy link
Contributor

grasmash commented Apr 26, 2017

@leonk Do you have a custom target defined somewhere? Possibly one in the tests namespace?

@leonk
Copy link
Contributor Author

leonk commented Apr 26, 2017

No I don't believe we have a custom target, we haven't modified BLT very much.

If I run blt tests:security-updates I get the same output (that it has been skipped). But blt doctor shows that error message.
Also (more importantly) on Travis is doesn't skip the security check.

@grasmash
Copy link
Contributor

Ah, I see. Ok that makes more sense to me. This should actually be resolved already in 8.x-dev, and this gives me some more reason to cut a 8.8.4 sooner.

@grasmash grasmash added Bug Something isn't working and removed Support A support request labels Apr 26, 2017
grasmash added a commit to grasmash/bolt that referenced this issue May 4, 2017
@grasmash grasmash self-assigned this May 4, 2017
grasmash added a commit to grasmash/bolt that referenced this issue May 4, 2017
grasmash added a commit to grasmash/bolt that referenced this issue May 8, 2017
grasmash pushed a commit that referenced this issue Feb 22, 2018
The error message says that `disable-targets.tests.security-updates` must be set to false if I want to disable security checks. This doesn't work. After searching around a bit, I found this comment: #1440 (comment). It seems that it should be set to true (and it makes sense, because the key name is `disable-targets`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants