Pipelines Recipe using wrong filename

[greggmarshall]

Describe the bug
The Acquia Pipelines init recipe uses the wrong filename. Running
blt recipes:ci:pipelines:init
copies the file acquia-pipelines.yml into the project root. When Acquia Pipelines runs with that file in Welcome step the error message
Pipelines could not find a acquia-pipelines.yaml in your repository's root directory.

Note the difference in the filename extension. According to the documentation at https://docs.acquia.com/cloud-platform/develop/pipelines/yaml/# the filename should be named acquia-pipelines.yaml

To Reproduce
Steps to reproduce the behavior, ideally starting from a fresh install of BLT:

1. Run composer create-project acquia/blt-project --no-interaction
2. Execute the blt recipes:ci:pipelines:init command
3. Verify that the file acquia-pipelines.yml file is created in project root

Expected behavior
Created file needs to be named acquia-pipelines.yaml

Validated by renaming the file and re-submitting the pipelines request.

Detailed error output
When Acquia Pipelines runs with that file in Welcome step the error message
Pipelines could not find a acquia-pipelines.yaml in your repository's root directory.

BLT doctor output
+---------------------------+---------------------------------------------------------+
| Property | Value |
+---------------------------+---------------------------------------------------------+
| %paths.%root | /home/ide/project/docroot |
| %paths.%site | sites/default |
| %paths.%modules | sites/all/modules |
| %paths.%themes | sites/all/themes |
| %paths.%config-sync | /home/ide/project/config/default |
| %paths.%files | sites/default/files |
| %paths.%temp | /tmp |
| %paths.%private | /mnt/files/biorad.ide/sites/default/files-private |
| admin-theme | seven |
| alias-searchpaths.0 | /home/ide/project/drush/sites |
| blt-version | Unknown |
| bootstrap | Successful |
| composer-version | Composer version 1.10.19 2020-12-04 09:14:16 |
| config-sync | /home/ide/project/config/default |
| db-driver | mysql |
| db-hostname | localhost |
| db-name | drupal |
| db-password | drupal |
| db-port | 3306 |
| db-status | Connected |
| db-username | drupal |
| drupal-settings-file | sites/default/settings.php |
| drupal-version | 9.1.0 |
| drush-alias-files.0 | /home/ide/project/drush/sites/biorad.site.yml |
| drush-cache-directory | /home/ide/.drush/cache |
| drush-conf.0 | /home/ide/.drush/drush.yml |
| drush-conf.1 | /home/ide/project/vendor/drush/drush/drush.yml |
| drush-conf.2 | /home/ide/project/drush/drush.yml |
| drush-conf.3 | /home/ide/project/docroot/sites/default/local.drush.yml |
| drush-script | /home/ide/project/vendor/drush/drush/drush |
| drush-temp | /tmp |
| drush-version | 10.3.6 |
| files | sites/default/files |
| install-profile | standard |
| modules | sites/all/modules |
| php-bin | /usr/local/php7.3/bin/php |
| php-conf.0 | /usr/local/php7.3/etc/cli/php.ini |
| php-os | Linux |
| private | /mnt/files/biorad.ide/sites/default/files-private |
| root | /home/ide/project/docroot |
| site | sites/default |
| stacks.drupal-vm.inited | false |
| stacks.dev-desktop.inited | false |
| temp | /tmp |
| theme | cohesion_theme |
| themes | sites/all/themes |
| uri | http://local.bio-rad.com |
+---------------------------+---------------------------------------------------------+
+--------------------------------------+-------------------------------------------------------------+
| Check | Problem |
+--------------------------------------+-------------------------------------------------------------+
| ComposerCheck:checkVersion | Composer 1 detected. |
| | Composer 1 is end of life, and Composer 2 includes |
| | significant performance improvements. Upgrade to Composer 2 |
| | as soon as possible. |
| NodeCheck:checkNodeVersionFileExists | Neither .nvmrc nor .node-version file found in repo root. |
| WebUriCheck:checkUriResponse | Did not get a response from http://local.bio-rad.com |
| | Is your *AMP stack running? |
| | Is your /etc/hosts file correctly configured? |
| | Is your web server configured to serve this URI from |
| | /home/ide/project/docroot? |
| | Is options.uri set correctly in |
| | /home/ide/project/docroot/sites/default/local.drush.yml? |
+--------------------------------------+-------------------------------------------------------------+

System information

• Operating system type: Acquia Cloud IDE
• Operating system version: Acquia Cloud IDE
• BLT version: blt --version returns "BLT:unknown"

Additional context
Add any other context about the problem here.

[danepowell]

Although the docs don't mention it, both extensions (yml and yaml) are valid. We can change BLT to be consistent with the docs.

That doesn't explain your error though. Are you sure that acquia-pipelins.yml/yaml has actually been committed to your linked repository? And that it's the same repo that's linked to pipelines, and the same branch you are starting a job from?

[greggmarshall]

That's interesting. As soon as I renamed the file in the project root and pushed it, I started getting pipelines builds (now working through the build errors).

Let me try renaming it back and pushing. It might have been unrelated since we're also having some issues with Bitbucket not reliably starting Pipelines due to some inconsistency in what Pipelines is expecting (we have Acquia Support engaged in that).

[greggmarshall]

Ok, it was a coincidence. I just tried renaming the file back to acquia-pipelines.yml and the build ran until the problem I'm debugging. Still would be a good idea to update the documentation.

[danepowell]

Glad it's working. If the Bitbucket issue is the same one I'm thinking of, I'm coordinating with support as well and if they haven't communicated it to you yet, you might try setting a display name on your Bitbucket account and see if that helps jobs start via the webhook.

I'll make sure the docs have a note about the filename variants.