Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance nuke command. #1493

Merged
merged 1 commit into from
May 9, 2017
Merged

Enhance nuke command. #1493

merged 1 commit into from
May 9, 2017

Conversation

dpagini
Copy link
Contributor

@dpagini dpagini commented May 9, 2017

Another random change for discussion.

Changes proposed:

  • The composer nuke command currently deletes vendor/ and composer.lock, clears cache and re-runs $ composer install. This change also deletes the common Drupal folders for core, modules/contrib, themes/contrib and profiles/contrib.
  • At first I was thinking this is a bit of an assumption, because users can actually put their contrib modules in somewhere other than docroot/modules/contrib, but at the same time, I can put my composer dependencies in something other than vendor/ too. The former is admittedly a little more common.
  • docroot/libraries/contrib felt a little too heavy handed, because it's equally as likely that composer is not managing that directory for a user. Happy to add it though if there are any thoughts there.

@grasmash grasmash merged commit 100cd9c into acquia:8.x May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants