Normalize and covert svg line endings to native on checkout #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. Drupal core includes an entry for |
greylabel
reviewed
Jul 14, 2017
template/.gitattributes
Outdated
| @@ -40,6 +40,7 @@ | |||
| *.txt text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | |||
| *.xml text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | |||
| *.yml text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | |||
| *.svg text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2 | |||
There was a problem hiding this comment.
This list should be kept in alphabetical order, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
There is no
.gitattributesentry for.svgfiles, which means we're relying on what ever the value ofcore.autocrlfis on each developers machine. I propose that we add a new entry totemplate/.gitattributesto set this on a per-repository basis.In my opinion,
.svgfiles should be treated as text so that their line endings will be converted to native on checkout. This makes sense to me because.svgfiles can be edited manually, and they are not binary files. If others disagree I'm happy to hear counter arguments.