Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent doctrine/inflector from advancing to 1.2.x. #1829

Merged
merged 2 commits into from
Jul 31, 2017
Merged

Prevent doctrine/inflector from advancing to 1.2.x. #1829

merged 2 commits into from
Jul 31, 2017

Conversation

timcosgrove
Copy link
Contributor

Changes proposed:

  • Fix doctrine/inflector on 1.1.x, as 1.2.x requires PHP7

As of 1.2.0 (https://github.com/doctrine/inflector/commits/v1.2.0) doctrine/inflector requires 7.0, rather than 5.6|7.0.

As Acquia has not yet rolled PHP7 out to production environments yet, we probably want to hold ourselves back.

See similar issue in for Laravel: laravel/framework#20214

@timcosgrove
Copy link
Contributor Author

Apologies. Getting myself set up w/ proper BLT development locally.

@timcosgrove
Copy link
Contributor Author

Added updated composer.lock, updated w/ composer update doctrine/inflector

@mikemadison13
Copy link
Contributor

FYI I posted about this over on the acquia/lightning space as well: https://github.com/acquia/lightning/issues/411

@timcosgrove
Copy link
Contributor Author

Yeah. On one hand, this can be resolved by using PHP 5.6 where you run composer update. On the other hand, I would imagine that many people who run BLT at all run Vagrant or Docker locally, which means they can run 5.6 in their vm/image and run whatever locally. You can take the trouble to run composer update in your VM at that point.

We'll probably just ask all our engineers to run 5.6 locally, but I'll leave this PR open for @grasmash to decline or to not decline.

@grasmash grasmash added the Enhancement A feature or feature request label Jul 31, 2017
@grasmash grasmash merged commit d17bd0b into acquia:8.x Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants