Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making security test failure more verbose. #231

Merged
merged 2 commits into from
Jul 19, 2016
Merged

Making security test failure more verbose. #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f0f831
Improving Drupal Scaffold docs.
grasmash Jul 19, 2016
85be4b6
Making security test failure more verbose.
grasmash Jul 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion template/build/core/phing/tasks/tests.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,21 @@
</target>

<!-- Ensure Drupal doesn't have any modules requiring security updates. -->
<!-- Intentionally removed checkreturn="true" so that this does not cause failure. -->
<target name="tests:security-updates"
description="Check local Drupal installation for security updates.">
<exec dir="${docroot}"
command="! ${drush.cmd} -n ups --check-disabled --security-only 2>/dev/null | grep 'SECURITY UPDATE'"
checkreturn="true"
logoutput="true"
returnProperty="securityPass"
passthru="true"/>

<!-- Output message on failure. -->
<if>
<not><equals arg1="${securityPass}" arg2="0"/></not>
<then>
<echo>One or more of your dependency has an outstanding security update. Please apply update(s) immediately. Failing build.</echo>
</then>
</if>
</target>
</project>
2 changes: 1 addition & 1 deletion template/readme/project-tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Note that Composer versioning is not identical to drupal.org versioning. See:

Drupal core files can be grouped into two categories: those that are within the `docroot/core` directory, and those that are directly within the `docroot` directory (scaffold files).

Scaffold files are automatically updated via the `drupal-composer/drupal-scaffold library`, which hooks into the `composer update` and `composer install` commands. If you would like to exclude any scaffold files from automated updates, see the [Drupal Scaffold configuration documentation](https://github.com/drupal-composer/drupal-scaffold#configuration). All other core files are updated in normal composer fashion.
Scaffold files are automatically updated via the `drupal-composer/drupal-scaffold library`, which hooks into the `composer update` and `composer install` commands. If you would like to exclude any scaffold files from automated updates (e.g., .htaccess or robots.txt), see the [Drupal Scaffold configuration documentation](https://github.com/drupal-composer/drupal-scaffold#configuration). All other core files are updated in normal composer fashion.

To update all drupal core files (scaffold and non-scaffold):

Expand Down