Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #784: Update to Drupal VM 4.0.x. #785

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Fixes #784: Update to Drupal VM 4.0.x. #785

merged 1 commit into from
Dec 12, 2016

Conversation

geerlingguy
Copy link
Contributor

Fixes #784.

Changes proposed:

  • Switch to Drupal VM 4.0.x series.
  • Use Node.js 4.x instead of 0.12 (Cog and other tools are requiring minimum of 4.x now).
  • Remove unnecessary variables from VM config.yml.

@geerlingguy
Copy link
Contributor Author

Net removal of 33 lines of code 👍

@geerlingguy geerlingguy mentioned this pull request Dec 10, 2016
Closed
7 tasks
@geerlingguy
Copy link
Contributor Author

Failure was on a Lightning test...

/home/travis/build/acquia/blt-project/docroot/profiles/contrib/lightning/tests/features/media/image.feature:20

Looks unrelated to the changes in this PR.

@grasmash grasmash added the Enhancement A feature or feature request label Dec 12, 2016
@grasmash grasmash merged commit 219287a into acquia:8.x Dec 12, 2016
@geerlingguy geerlingguy deleted the dvm-4 branch March 21, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement A feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geerlingguy @grasmash