Fixed memcache contamination. #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
force-pushed
the
feature/memcache-fix
branch
from
a0842df
to
1df8088
Compare
grasmash
suggested changes
Dec 20, 2016
| @@ -15,7 +15,7 @@ | |||
| "drupal/cog": "^1.0.0", | |||
| "drupal/core": "^8.0", | |||
| "drupal/features": "^3.0.0", | |||
| "drupal/memcache": "^2.0.0-alpha2", | |||
| "drupal/memcache": "2.x-dev", | |||
There was a problem hiding this comment.
Please specify a hash since this has a patch applied against it.
There was a problem hiding this comment.
Hmm I don't think there's a patch against it but I can still lock it to a hash tomorrow.
There was a problem hiding this comment.
Oh I see. I noticed that a patch had changed in this PR and assumed it was for memcache. Looks like it's actually just a whitespace change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed odd behavior on our dev/stage sites (which share the same hardware) where cache keys were very clearly being shared between sites. For instance, we deployed a module to dev, and then got routing errors on stage indicating that Drupal was looking for that module.
My theory is that the memcache module is not properly prefixing keys per host. It appears that the ACE server-side includes do configure these keys correctly, and the memcache store uses them correctly about 99% of the time. But if the key is too long, the memcache module hashes it and I think this is the case where the hostname is ignored and caches can become contaminated across multiple sites on the same server.
This is fixed upstream here, so updating to dev should fix it: https://www.drupal.org/node/2701903
I also requested a new alpha release, so we can get back off of dev ASAP: https://www.drupal.org/node/2837857