Replace PHPStan with drupal-check for deprecation testing #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PHPStan installed directly in the fixture with drupal-check installed in ORCA itself, for two benefits: 1) it improves the resiliency of deprecation testing, making it less susceptible to total failure from errors in tested code, and 2) it improves the production-likeness of the fixture by removing packages that aren't strictly necessary and can't be assumed to be present in a customer build.
If you were depending on PHPStan being in the fixture, you can add it back yourself in a custom script: