Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jobs work on Drupal 10 #279

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Make jobs work on Drupal 10 #279

merged 5 commits into from
Sep 13, 2022

Conversation

secretsayan
Copy link
Contributor

No description provided.

@secretsayan secretsayan force-pushed the ORCA-421 branch 2 times, most recently from 89fb21a to 9f4ce92 Compare August 29, 2022 06:39
@secretsayan secretsayan changed the title ORCA-421: Strip out config.platform setting during fixture creation ORCA-421: Strip out config.platform setting and remove acquia/drupal-minimal-project Aug 29, 2022
@secretsayan secretsayan changed the title ORCA-421: Strip out config.platform setting and remove acquia/drupal-minimal-project ORCA-421: Strip out config.platform setting Aug 29, 2022
@danepowell
Copy link
Contributor

I would suggest not removing config platform universally, but only for jobs that you know conflict with it, i.e. Drupal 10.

For instance, if the config platform for some reason caused Drupal 9 installs to fail, that's an error that we would want ORCA to catch.

@TravisCarden
Copy link
Contributor

@danepowell, wouldn't removing config.platform.php only for Drupal 10 conflict with acquia/drupal-recommended-project#220, where you're trying to increase it to 8.0? It seems like that would cause all of our PHP 7.4 jobs to fail. Am I missing something?

@danepowell
Copy link
Contributor

I guess "jobs we know to fail" would then include Drupal 10 jobs and PHP 7.4 jobs.

If it's easier to just remove the config from every job, I won't complain.

@secretsayan secretsayan force-pushed the ORCA-421 branch 4 times, most recently from f476126 to ae137ca Compare September 1, 2022 12:17
@secretsayan secretsayan changed the title ORCA-421: Strip out config.platform setting ORCA-421: Drupal 10 readiness Sep 2, 2022
TravisCarden
TravisCarden requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@TravisCarden TravisCarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A handful of minor points.

src/Domain/Fixture/FixtureCreator.php Outdated Show resolved Hide resolved
src/Domain/Fixture/FixtureCreator.php Outdated Show resolved Hide resolved
src/Domain/Fixture/SiteInstaller.php Show resolved Hide resolved
src/Domain/Tool/Phpunit/PhpUnitTask.php Outdated Show resolved Hide resolved
src/Options/FixtureOptions.php Outdated Show resolved Hide resolved
src/Options/FixtureOptions.php Outdated Show resolved Hide resolved
tests/Domain/Composer/ComposerFacadeTest.php Outdated Show resolved Hide resolved
tests/Domain/Composer/ComposerFacadeTest.php Outdated Show resolved Hide resolved
@TravisCarden TravisCarden changed the title ORCA-421: Drupal 10 readiness Make jobs work on Drupal 10 Sep 13, 2022
@TravisCarden TravisCarden merged commit b2be11f into acquia:develop Sep 13, 2022
@secretsayan secretsayan deleted the ORCA-421 branch February 19, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisCarden TravisCarden TravisCarden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@secretsayan @danepowell @TravisCarden