Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chromedriver edge case #285

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

secretsayan
Copy link
Contributor

No description provided.

@secretsayan
Copy link
Contributor Author

@TravisCarden : Please review this PR as well, this is an improvement on #277. This is based on https://chromedriver.chromium.org/downloads/version-selection

Copy link
Contributor

@TravisCarden TravisCarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to comments. Nothing more.

bin/ci/before_install.sh Outdated Show resolved Hide resolved
bin/ci/before_install.sh Show resolved Hide resolved
bin/ci/before_install.sh Show resolved Hide resolved
bin/ci/before_install.sh Show resolved Hide resolved
@TravisCarden TravisCarden merged commit 9d25626 into acquia:develop Sep 26, 2022
@secretsayan secretsayan deleted the chrome-driver-fix branch February 19, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants