Domo Integration #350
Merged
Domo Integration #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secretsayan
force-pushed
the
orca-96
branch
8 times, most recently
from
9a5b10c to
8fd9619
Compare
secretsayan
force-pushed
the
orca-96
branch
3 times, most recently
from
a0f7189 to
019e45b
Compare
secretsayan
force-pushed
the
orca-96
branch
2 times, most recently
from
b972913 to
8788557
Compare
secretsayan
force-pushed
the
orca-96
branch
3 times, most recently
from
336267d to
e3e7c26
Compare
TravisCarden
requested changes
Jun 12, 2023
src/Helper/Log/GoogleApiClient.php
Outdated
Comment on lines
75
to
80
| public function __construct(HttpClientInterface $http_client, | ||
| SymfonyStyle $output, | ||
| DrupalCoreVersionResolver $coreVersionResolver, | ||
| $google_api_client_id, | ||
| $google_api_client_secret, | ||
| $google_refresh_token) { |
There was a problem hiding this comment.
The string arguments can be type-hinted.
There was a problem hiding this comment.
Please re-check this one and let me know what do you think.
Comment on lines
+429
to
+430
| // Assigning to null as beta or later version does not exist. | ||
| $this->nextMajorLatestMinorBetaOrLater = NULL; |
There was a problem hiding this comment.
What is this for? The method name indicates that it's an assertion, which probably shouldn't have any side effects, and if this line runs it will always be immediately followed by an exception.
There was a problem hiding this comment.
Please suggest a function name instead of assertNextMajorLatestMinorBetaOrLaterExists :)
Co-authored-by: Travis Carden <travis.carden@gmail.com>
Co-authored-by: Travis Carden <travis.carden@gmail.com>
Co-authored-by: Travis Carden <travis.carden@gmail.com>
Co-authored-by: Travis Carden <travis.carden@gmail.com>
Co-authored-by: Travis Carden <travis.carden@gmail.com>
TravisCarden
approved these changes
Jun 13, 2023
secretsayan
pushed a commit
to secretsayan/orca
that referenced
this pull request
Jul 11, 2023
* Initial Working implementation * use event dispatcher compatible with php 7.4 * Dont send data when test is skipped * Add env variables to github action workflow * Resolve issues * Fix lock files * Fix all issues * Update src/Console/Command/Ci/CiRunCommand.php Co-authored-by: Travis Carden <travis.carden@gmail.com> * Update src/Enum/EnvVarEnum.php Co-authored-by: Travis Carden <travis.carden@gmail.com> * Update src/Helper/Log/GoogleApiClient.php Co-authored-by: Travis Carden <travis.carden@gmail.com> * Update src/Helper/Log/GoogleApiClient.php Co-authored-by: Travis Carden <travis.carden@gmail.com> * Update src/Helper/Log/GoogleApiClient.php Co-authored-by: Travis Carden <travis.carden@gmail.com> * PR feedback * Changes related to Exit Early Save --------- Co-authored-by: Travis Carden <travis.carden@gmail.com>
|
@secretsayan @TravisCarden it looks like the ORCA workflow example integration was never updated to add these new secrets. Was that intentional? https://github.com/acquia/orca/blob/develop/example/.github/workflows/orca.yml |
|
@danepowell Thanks for pointing this out. PR #425 created to modify example files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.