Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions #405

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Fix exceptions #405

merged 3 commits into from
Jun 19, 2023

Conversation

secretsayan
Copy link
Contributor

@secretsayan secretsayan commented Jun 16, 2023

  • Since ORCA's self tests do not use the config/packages.yml we are adding the dependencies in example/tests/packages_alter.yml so that they can be picked up during fixture creation.

@secretsayan secretsayan marked this pull request as draft June 16, 2023 11:10
@secretsayan secretsayan force-pushed the fix-exception branch 4 times, most recently from d9cfcb8 to c4b3d04 Compare June 16, 2023 11:25
@secretsayan secretsayan requested a review from TravisCarden June 16, 2023 11:37
@secretsayan secretsayan marked this pull request as ready for review June 16, 2023 11:37
Copy link
Contributor

@TravisCarden TravisCarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

secretsayan and others added 2 commits June 17, 2023 10:20
Co-authored-by: Travis Carden <travis.carden@gmail.com>
@secretsayan secretsayan merged commit 7c13014 into acquia:develop Jun 19, 2023
secretsayan pushed a commit to secretsayan/orca that referenced this pull request Jul 11, 2023
* Fix all issues

* Update src/Helper/Log/GoogleApiClient.php

Co-authored-by: Travis Carden <travis.carden@gmail.com>

* Revert return value changes

---------

Co-authored-by: Travis Carden <travis.carden@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants