config(gms): enable elasticsearch reindex by default

acryldata · Jan 10, 2023 · 13da26e · 13da26e
1 parent 086025d
commit 13da26e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml
@@ -4,13 +4,13 @@ description: A Helm chart for LinkedIn DataHub
 type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.2.131
+version: 0.2.132
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
 appVersion: 0.9.5
 dependencies:
   - name: datahub-gms
-    version: 0.2.130
+    version: 0.2.131
     repository: file://./subcharts/datahub-gms
     condition: datahub-gms.enabled
   - name: datahub-frontend

diff --git a/charts/datahub/subcharts/datahub-gms/Chart.yaml b/charts/datahub/subcharts/datahub-gms/Chart.yaml
@@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component
 type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.2.130
+version: 0.2.131
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
 appVersion: v0.9.5
diff --git a/charts/datahub/subcharts/datahub-gms/templates/deployment.yaml b/charts/datahub/subcharts/datahub-gms/templates/deployment.yaml
@@ -229,6 +229,14 @@ spec:
             {{- end }}
             - name: SEARCH_SERVICE_ENABLE_CACHE
               value: {{ .Values.global.datahub.enable_search_cache | quote }}
+            {{- with .Values.global.elasticsearch.index.enableMappingsReindex }}
+            - name: ELASTICSEARCH_INDEX_BUILDER_MAPPINGS_REINDEX
+              value: {{ . | quote }}
+            {{- end }}
+            {{- with .Values.global.elasticsearch.index.enableSettingsReindex }}
+            - name: ELASTICSEARCH_INDEX_BUILDER_SETTINGS_REINDEX
+              value: {{ . | quote }}
+            {{- end }}
           {{- with .Values.extraEnvs }}
             {{- toYaml . | nindent 12 }}
           {{- end }}

diff --git a/charts/datahub/values.yaml b/charts/datahub/values.yaml
@@ -192,12 +192,12 @@ global:
     ## The following section controls when and how reindexing of elasticsearch indices are performed
     index:
       ## Enable reindexing when mappings change based on the data model annotations
-      enableMappingsReindex: false
+      enableMappingsReindex: true
 
       ## Enable reindexing when static index settings change.
       ## Dynamic settings which do not require reindexing are not affected
       ## Primarily this should be enabled when re-sharding is necessary for scaling/performance.
-      enableSettingsReindex: false
+      enableSettingsReindex: true
 
       ## Index settings can be overridden for entity indices or other indices on an index by index basis
       ## Some index settings, such as # of shards, requires reindexing while others, i.e. replicas, do not