Skip to content

Commit

Permalink
fix: move default tag to global.datahub.version (#214)
Browse files Browse the repository at this point in the history
image.tag in datahub-gms and datahub-fronted shadowed the
global.datahub.version from the top datahub chart, so the resulting
image was head.
  • Loading branch information
daha authored Dec 27, 2022
1 parent e4bec71 commit 8af00f4
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
6 changes: 3 additions & 3 deletions charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.120
version: 0.2.121
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.9.1
dependencies:
- name: datahub-gms
version: 0.2.120
version: 0.2.121
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.120
version: 0.2.121
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.120
version: 0.2.121
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.9.3
3 changes: 2 additions & 1 deletion charts/datahub/subcharts/datahub-frontend/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ revisionHistoryLimit: 10

image:
repository: linkedin/datahub-frontend-react
tag: "head"
tag:
pullPolicy: IfNotPresent

imagePullSecrets: []
Expand Down Expand Up @@ -199,6 +199,7 @@ global:
server: "broker:9092"

datahub:
version: head
gms:
port: "8080"
appVersion: "1.0"
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for LinkedIn DataHub's datahub-gms component
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.120
version: 0.2.121
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.9.3
3 changes: 2 additions & 1 deletion charts/datahub/subcharts/datahub-gms/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ revisionHistoryLimit: 10
image:
repository: linkedin/datahub-gms
pullPolicy: IfNotPresent
tag: head
tag:

imagePullSecrets: []
nameOverride: ""
Expand Down Expand Up @@ -151,6 +151,7 @@ global:
secretKey: "mysql-password"

datahub:
version: head
monitoring:
enablePrometheus: false
enableJMXPort: false
Expand Down

0 comments on commit 8af00f4

Please sign in to comment.