Skip to content

Commit

Permalink
feat(throttle): add pending throttling controls for v0.14.2 (#510)
Browse files Browse the repository at this point in the history
  • Loading branch information
david-leifker authored Oct 10, 2024
1 parent e7a3562 commit 940132e
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 5 deletions.
6 changes: 3 additions & 3 deletions charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ description: A Helm chart for DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.4.29
version: 0.4.30
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.14.1
dependencies:
- name: datahub-gms
version: 0.2.173
version: 0.2.174
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
Expand All @@ -22,7 +22,7 @@ dependencies:
repository: file://./subcharts/datahub-mae-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-mce-consumer
version: 0.2.164
version: 0.2.165
repository: file://./subcharts/datahub-mce-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-ingestion-cron
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for DataHub's datahub-gms component
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.173
version: 0.2.174
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.14.1
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,10 @@ spec:
- name: MCP_THROTTLE_UPDATE_INTERVAL_MS
value: {{ . | quote }}
{{- end }}
{{- with .apiRequests.enabled }}
- name: MCP_API_REQUESTS_THROTTLE_ENABLED
value: {{ . | quote }}
{{- end }}
{{- if .versioned.enabled }}
- name: MCP_VERSIONED_THROTTLE_ENABLED
value: "true"
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ description: A Helm chart for Kubernetes
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.164
version: 0.2.165
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: v0.14.1
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ spec:
- name: MCP_THROTTLE_UPDATE_INTERVAL_MS
value: {{ . | quote }}
{{- end }}
{{- with .mceConsumer.enabled }}
- name: MCP_MCE_CONSUMER_THROTTLE_ENABLED
value: {{ . | quote }}
{{- end }}
{{- if .versioned.enabled }}
- name: MCP_VERSIONED_THROTTLE_ENABLED
value: "true"
Expand Down
4 changes: 4 additions & 0 deletions charts/datahub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,10 @@ global:
mcp:
throttle:
# updateIntervalMs: 60000
mceConsumer: # v0.14.2+
enabled: false
apiRequests: # v0.14.2+
enabled: false
## Versioned MCL topic
versioned:
## Whether to throttle MCP processing based on MCL backlog
Expand Down

0 comments on commit 940132e

Please sign in to comment.