feat(upgrade): allow setting batch args (#155)

acryldata · Aug 23, 2022 · a70d943 · a70d943
1 parent 344dae5
commit a70d943
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/charts/datahub/Chart.yaml b/charts/datahub/Chart.yaml
@@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
 type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.2.89
+version: 0.2.90
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
 appVersion: 0.8.43

diff --git a/charts/datahub/templates/datahub-upgrade/datahub-restore-indices-job-template.yml b/charts/datahub/templates/datahub-upgrade/datahub-restore-indices-job-template.yml
@@ -67,6 +67,10 @@ spec:
               args:
                 - "-u"
                 - "RestoreIndices"
+                - "-a"
+                - "batchSize={{ .Values.datahubUpgrade.batchSize }}"
+                - "-a"
+                - "batchDelayMs={{ .Values.datahubUpgrade.batchDelayMs }}"
               env:
                 {{- include "datahub.upgrade.env" . | nindent 16}}
               {{- with .Values.datahubUpgrade.extraEnvs }}

diff --git a/charts/datahub/templates/datahub-upgrade/datahub-upgrade-job.yml b/charts/datahub/templates/datahub-upgrade/datahub-upgrade-job.yml
@@ -66,9 +66,9 @@ spec:
             - "-u"
             - "NoCodeDataMigration"
             - "-a"
-            - "batchSize=1000"
+            - "batchSize={{ .Values.datahubUpgrade.batchSize }}"
             - "-a"
-            - "batchDelayMs=100"
+            - "batchDelayMs={{ .Values.datahubUpgrade.batchDelayMs }}"
             - "-a"
             - "dbType={{ .Values.datahubUpgrade.noCodeDataMigration.sqlDbType }}"
           env:

diff --git a/charts/datahub/values.yaml b/charts/datahub/values.yaml
@@ -92,6 +92,8 @@ datahubUpgrade:
   image:
     repository: acryldata/datahub-upgrade
     tag: "v0.8.43"
+  batchSize: 1000
+  batchDelayMs: 100
   noCodeDataMigration:
     sqlDbType: "MYSQL"
   podSecurityContext: {}