Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): allow setting batch args #155

Merged
merged 1 commit into from
Aug 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.89
version: 0.2.90
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.8.43
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ spec:
args:
- "-u"
- "RestoreIndices"
- "-a"
- "batchSize={{ .Values.datahubUpgrade.batchSize }}"
- "-a"
- "batchDelayMs={{ .Values.datahubUpgrade.batchDelayMs }}"
env:
{{- include "datahub.upgrade.env" . | nindent 16}}
{{- with .Values.datahubUpgrade.extraEnvs }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ spec:
- "-u"
- "NoCodeDataMigration"
- "-a"
- "batchSize=1000"
- "batchSize={{ .Values.datahubUpgrade.batchSize }}"
- "-a"
- "batchDelayMs=100"
- "batchDelayMs={{ .Values.datahubUpgrade.batchDelayMs }}"
- "-a"
- "dbType={{ .Values.datahubUpgrade.noCodeDataMigration.sqlDbType }}"
env:
Expand Down
2 changes: 2 additions & 0 deletions charts/datahub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ datahubUpgrade:
image:
repository: acryldata/datahub-upgrade
tag: "v0.8.43"
batchSize: 1000
batchDelayMs: 100
noCodeDataMigration:
sqlDbType: "MYSQL"
podSecurityContext: {}
Expand Down