Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts): add an option to configure revisionHistoryLimit to subcharts #159

Merged
merged 10 commits into from
Sep 12, 2022
10 changes: 5 additions & 5 deletions charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,25 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.92
version: 0.2.93
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.8.44
dependencies:
- name: datahub-gms
version: 0.2.5
version: 0.2.7
repository: file://./subcharts/datahub-gms
condition: datahub-gms.enabled
- name: datahub-frontend
version: 0.2.4
version: 0.2.5
repository: file://./subcharts/datahub-frontend
condition: datahub-frontend.enabled
- name: datahub-mae-consumer
version: 0.2.5
version: 0.2.6
repository: file://./subcharts/datahub-mae-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-mce-consumer
version: 0.2.6
version: 0.2.7
repository: file://./subcharts/datahub-mce-consumer
condition: global.datahub_standalone_consumers_enabled
- name: datahub-ingestion-cron
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-frontend/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.4
version: 0.2.5

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ metadata:
{{- include "datahub-frontend.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.replicaCount }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
matchLabels:
{{- include "datahub-frontend.selectorLabels" . | nindent 6 }}
Expand Down
2 changes: 2 additions & 0 deletions charts/datahub/subcharts/datahub-frontend/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

replicaCount: 1

revisionHistoryLimit: 10

image:
repository: linkedin/datahub-frontend-react
tag: "head"
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-gms/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.6
version: 0.2.7

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ metadata:
{{- include "datahub-gms.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.replicaCount }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
matchLabels:
{{- include "datahub-gms.selectorLabels" . | nindent 6 }}
Expand Down
12 changes: 7 additions & 5 deletions charts/datahub/subcharts/datahub-gms/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

replicaCount: 1

revisionHistoryLimit: 10

image:
repository: linkedin/datahub-gms
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -42,8 +44,8 @@ service:
targetPort: http
protocol: TCP
name: http
# Annotations to add to the service, this will help in adding
# Internal load balancer or various other annotation support in AWS
# Annotations to add to the service, this will help in adding
# Internal load balancer or various other annotation support in AWS
annotations: {}
# service.beta.kubernetes.io/aws-load-balancer-internal: "true"

Expand Down Expand Up @@ -152,12 +154,12 @@ global:

managed_ingestion:
enabled: true
# defaultCliVersion: "X.X.X" --> Optional: Controls the acryl-datahub package version downloaded from PyPI.
# defaultCliVersion: "X.X.X" --> Optional: Controls the acryl-datahub package version downloaded from PyPI.

metadata_service_authentication:
metadata_service_authentication:
enabled: false
# tokenService:
# signingKey:
# signingKey:
# secretRef: <secret-ref>
# secretKey: <secret-key>
# salt:
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mae-consumer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.5
version: 0.2.6

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ metadata:
{{- include "datahub-mae-consumer.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.replicaCount }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
matchLabels:
{{- include "datahub-mae-consumer.selectorLabels" . | nindent 6 }}
Expand Down
4 changes: 3 additions & 1 deletion charts/datahub/subcharts/datahub-mae-consumer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

replicaCount: 1

revisionHistoryLimit: 10

image:
repository: linkedin/datahub-mae-consumer
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -176,7 +178,7 @@ global:
mae_consumer:
port: "9091"

metadata_service_authentication:
metadata_service_authentication:
enabled: false
systemClientId: "__datahub_system"
# systemClientSecret:
Expand Down
2 changes: 1 addition & 1 deletion charts/datahub/subcharts/datahub-mce-consumer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.6
version: 0.2.7

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ metadata:
{{- include "datahub-mce-consumer.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.replicaCount }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
matchLabels:
{{- include "datahub-mce-consumer.selectorLabels" . | nindent 6 }}
Expand Down
6 changes: 4 additions & 2 deletions charts/datahub/subcharts/datahub-mce-consumer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

replicaCount: 1

revisionHistoryLimit: 10

image:
repository: linkedin/datahub-mce-consumer
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -156,7 +158,7 @@ global:
enablePrometheus: false
gms:
port: "8080"
metadata_service_authentication:
metadata_service_authentication:
enabled: false
systemClientId: "__datahub_system"
# systemClientSecret:
Expand All @@ -169,4 +171,4 @@ global:
- "broker"
- "mysql"
- "elasticsearch"
- "neo4j"
- "neo4j"