-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): deprecation of prerequisites helm chart and helm hooks, more reliable deployment, more stable #294
Closed
justmike1
wants to merge
13
commits into
acryldata:master
from
justmike1:feature/deprecate_prerequisites
Closed
feat(helm): deprecation of prerequisites helm chart and helm hooks, more reliable deployment, more stable #294
justmike1
wants to merge
13
commits into
acryldata:master
from
justmike1:feature/deprecate_prerequisites
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em upgrade cleanup
the large number of files changed is only because of folder hierarchy change |
Done with the PR, commited last one. would like a review, this would be a major improver for the chart IMO |
I see how maybe reviewing this with the folder change is too much, I will create a new PR with only the features, folder change can be done on another pr |
Signed-off-by: Mike Joseph <mikejoseph@Mikes-MacBook-Pro.local>
Signed-off-by: Mike Joseph <mikejoseph@Mikes-MacBook-Pro.local>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Context
Being dependent on another helm chart and using helm hooks for proper deployment making introduces number of issues, for example:
google marketplace uses helm charts for templates and then kubectl one by one, which makes using this chart for it impossible.
if a user deploys prerequisites without the
--wait
flag (like in the docs) and doesn't wait for deployments to finish and straight away deploys datahub, the pods will continually restart until ready.GMS authentication breaks datahub-system-update-job #265
Many more tools that doesn't support helm hooks while using helm for packaging templates per services
The change
I introduce the same methodology of dependent deployments but with init containers, they will check if the needed service is ready before initiating the main pod
TESTS
You can use this repository meanwhile to test this feature
Notes
TODO
Maintenance
I will continue maintaining and improve the chart, but this is a good init start, I don't want this PR to be a too major change unrelated to the goal (which is one helm chart for all).