Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): deprecation of prerequisites helm chart and helm hooks, more reliable deployment, more stable #294

Closed
wants to merge 13 commits into from
Closed

Conversation

justmike1
Copy link
Contributor

@justmike1 justmike1 commented Apr 5, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Context

Being dependent on another helm chart and using helm hooks for proper deployment making introduces number of issues, for example:

  • google marketplace uses helm charts for templates and then kubectl one by one, which makes using this chart for it impossible.

  • if a user deploys prerequisites without the --wait flag (like in the docs) and doesn't wait for deployments to finish and straight away deploys datahub, the pods will continually restart until ready.

  • GMS authentication breaks datahub-system-update-job #265

  • Many more tools that doesn't support helm hooks while using helm for packaging templates per services

The change

I introduce the same methodology of dependent deployments but with init containers, they will check if the needed service is ready before initiating the main pod

TESTS

You can use this repository meanwhile to test this feature

Notes

TODO

  • update docs

Maintenance

I will continue maintaining and improve the chart, but this is a good init start, I don't want this PR to be a too major change unrelated to the goal (which is one helm chart for all).

@justmike1 justmike1 changed the title deprecation of prerequisites helm chart and helm hooks, more reliable deployment, more stable feat(helm): deprecation of prerequisites helm chart and helm hooks, more reliable deployment, more stable Apr 6, 2023
@justmike1
Copy link
Contributor Author

justmike1 commented Apr 9, 2023

the large number of files changed is only because of folder hierarchy change

@justmike1
Copy link
Contributor Author

Done with the PR, commited last one. would like a review, this would be a major improver for the chart IMO

@justmike1
Copy link
Contributor Author

I see how maybe reviewing this with the folder change is too much, I will create a new PR with only the features, folder change can be done on another pr

Mike Joseph added 3 commits April 11, 2023 15:11
Signed-off-by: Mike Joseph <mikejoseph@Mikes-MacBook-Pro.local>
Signed-off-by: Mike Joseph <mikejoseph@Mikes-MacBook-Pro.local>
@justmike1
Copy link
Contributor Author

#297

@justmike1 justmike1 closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant