Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Project Template - Use a newer configuration for eslintrc #97

Merged
merged 1 commit into from
Jan 13, 2023
Merged

[IMP] Project Template - Use a newer configuration for eslintrc #97

merged 1 commit into from
Jan 13, 2023

Conversation

FrancoMaxime
Copy link
Contributor

The previous eslinrtc configuration file wasn't working with odoo 16, because the sourceType key was missing.
Upgrade ecmaVersion to 2019 adds new tokens that are used in odoo JS.

@FrancoMaxime FrancoMaxime self-assigned this Jan 13, 2023
@FrancoMaxime FrancoMaxime requested a review from sbidoul January 13, 2023 10:33
@sbidoul
Copy link
Member

sbidoul commented Jan 13, 2023

Thanks. It might be worth looking if we have interesting difference with the OCA one.

@sbidoul sbidoul merged commit 37f8f19 into master Jan 13, 2023
@acsone-git-bot acsone-git-bot deleted the mfr_update_eslintrc branch January 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBinsfeld ThomasBinsfeld Awaiting requested review from ThomasBinsfeld

@sbidoul sbidoul Awaiting requested review from sbidoul

Assignees

@FrancoMaxime FrancoMaxime

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrancoMaxime @sbidoul