Silence Environment.manage warning in Odoo 15

[sbidoul]

closes #43

And a few other internal improvements.

[codecov-commenter]

Codecov Report

Merging #45 (e970c6c) into master (506f5f8) will increase coverage by 0.95%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   83.85%   84.81%   +0.95%     
==========================================
  Files           6        7       +1     
  Lines         223      237      +14     
  Branches       31       33       +2     
==========================================
+ Hits          187      201      +14     
  Misses         25       25              
  Partials       11       11              

Impacted Files	Coverage Δ
click_odoo/compat.py	77.77% <77.77%> (ø)
click_odoo/__init__.py	100.00% <100.00%> (ø)
click_odoo/env.py	80.76% <100.00%> (+8.26%)	⬆️
click_odoo/env_options.py	94.23% <100.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506f5f8...e970c6c. Read the comment docs.

[joao-p-marques]

Thanks for the fixes @sbidoul 👍

I am trying this patch but I am still getting warnings when using this in conjunction with click-odoo-contrib, when hitting this line:

click-odoo/click_odoo/env_options.py

Line 213 in e970c6c

with odoo.api.Environment.manage():

2021-10-08 09:06:25,941 1 WARNING ? py.warnings: /usr/local/lib/python3.8/contextlib.py:113: DeprecationWarning: Since Odoo 15.0, Environment.manage() is useless.
  File "/usr/local/bin/click-odoo-dropdb", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/site-packages/click_odoo/env_options.py", line 213, in _invoke
    with odoo.api.Environment.manage():
  File "/usr/local/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)

2021-10-08 09:06:32,738 1 WARNING ? py.warnings: /usr/local/lib/python3.8/contextlib.py:113: DeprecationWarning: Since Odoo 15.0, Environment.manage() is useless.
  File "/usr/local/bin/click-odoo-initdb", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/site-packages/click_odoo/env_options.py", line 213, in _invoke
    with odoo.api.Environment.manage():
  File "/usr/local/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)

[sbidoul]

That's weird. Are you sure you are on the 15.0 branch and not 14.5 ?

[joao-p-marques]

That's weird. Are you sure you are on the 15.0 branch and not 14.5 ?

Yes, I am using the OCA/OCB fork but on branch 15.0.

The warning actually makes sense because the line I mentioned still makes a direct call to odoo.api.Environment.manage(), which should be replaced by a call to environment_manage(), as you did in the other cases, right?

Or is this line not supposed to be hit at all?

[sbidoul]

Ah right, I see it now. It should be fixed now. Thanks.

[joao-p-marques]

Thanks 👍 Tested and works as expected now 🙂