Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log message for updating remotes #57

Merged

Conversation

ap-wtioit
Copy link
Contributor

@ap-wtioit ap-wtioit commented Oct 20, 2021

@sbidoul
Copy link
Member

sbidoul commented Oct 20, 2021

Can you please add a towncrier newsfragment instead of modifying the changelog ?

@ap-wtioit
Copy link
Contributor Author

I will have a look how that works.

I had a look at the last merged pull request #54 and the https://github.com/acsone/git-aggregator/blob/master/DEVELOP.rst and both still updated/mentioned the README.rst

Should i update the DEVELOP.rst as well?

@sbidoul
Copy link
Member

sbidoul commented Oct 20, 2021

Hm, no you are right, this project does not use towncrier.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #57 (87a7133) into master (1047659) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   81.44%   81.44%           
=======================================
  Files           6        6           
  Lines         388      388           
=======================================
  Hits          316      316           
  Misses         72       72           
Impacted Files Coverage Δ
git_aggregator/repo.py 70.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1047659...87a7133. Read the comment docs.

@sbidoul sbidoul merged commit 13d81b8 into acsone:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants