Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web-vitals measuring and event tracking #2619

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add web-vitals measuring and event tracking #2619

merged 1 commit into from
Feb 3, 2021

Conversation

schamp
Copy link
Contributor

@schamp schamp commented Feb 2, 2021

@vercel
Copy link

vercel bot commented Feb 2, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/covidactnow/covid-projections/229k4a7re
✅ Preview: https://covid-projections-git-feature-fcp-tracking.covidactnow.now.sh

@schamp schamp requested a review from pnavarrc February 2, 2021 03:35
@schamp
Copy link
Contributor Author

schamp commented Feb 2, 2021

image
Looks like the events are getting sent to Analytics (from the test deployment on vercel)

pnavarrc
pnavarrc approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@pnavarrc pnavarrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well, I just added a suggestion on naming the Event Actions so the reports look nicer in Google Analytics.

Feel free to merge after fixing the linting warnings and renaming the event actions. Thanks for pushing this change!

src/components/Analytics/utils.ts Outdated Show resolved Hide resolved
src/components/Analytics/utils.ts Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
@schamp schamp merged commit f50c1d1 into develop Feb 3, 2021
@schamp schamp deleted the feature/fcp-tracking branch February 3, 2021 02:48
@pnavarrc pnavarrc added the performance Making the application faster label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnavarrc pnavarrc pnavarrc approved these changes

Assignees
No one assigned
Labels
performance Making the application faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schamp @pnavarrc