Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contrast survey updates #1961

Merged
merged 13 commits into from
Nov 23, 2022

Conversation

tombrunet
Copy link
Collaborator

Changes include:

  • Removes the restriction of applicability to widgets. Maintains exclusion for disabled widgets.
    • This caused inapplicable examples to now passed using default browser colors
    • Created two failing testcases using buttons with CSS colors
  • Clarifies how to compute the maximum possible contrast between two sets of colors.
  • Add shadow to minimum contrast, similar to how it was applied to enhanced contrast

Notes:

Closes issue(s):

Need for Call for Review:
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this.


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • [ x Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@tombrunet tombrunet added Rule Use this label for a new rule that does not exist already Definition labels Oct 20, 2022
@tombrunet tombrunet self-assigned this Oct 20, 2022
_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-enhanced-09o5cg.md Outdated Show resolved Hide resolved
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wait, the other one :-) I'd like some examples.

@WilcoFiers WilcoFiers dismissed their stale review November 3, 2022 14:10

Updated, check again

Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-enhanced-09o5cg.md Show resolved Hide resolved
pages/glossary/highest-possible-contrast.md Outdated Show resolved Hide resolved
@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Nov 14, 2022
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments. Nothing is blocking.

I think we could also have test cases with other widgets than button.

_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-afw4f7.md Show resolved Hide resolved
_rules/text-contrast-enhanced-09o5cg.md Show resolved Hide resolved
_rules/text-contrast-enhanced-09o5cg.md Show resolved Hide resolved
pages/glossary/highest-possible-contrast.md Show resolved Hide resolved
@WilcoFiers WilcoFiers merged commit 4739a28 into act-rules:develop Nov 23, 2022
@Jym77 Jym77 mentioned this pull request Nov 24, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Definition Review Call 1 week Call for review for small changes Rule Use this label for a new rule that does not exist already
Projects
None yet
7 participants