Update ee13b5 and 1a02b0 rules to clarify that transcript for video content does not need to be visible #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomo-petri
requested review from
Jym77,
kengdoj,
carlosapaduarte and
bruce-usab
giacomo-petri
changed the title
Jym77
previously requested changes
May 23, 2024
Comment on lines
+151
to
+164
| #### Failed Example 3 | ||
| This `video` element has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][]. | ||
| ```html | ||
| <html lang="en"> | ||
| <video controls> | ||
| <source src="/test-assets/rabbit-video/video.mp4" type="video/mp4"></source> | ||
| <source src="/test-assets/rabbit-video/video.webm" type="video/webm"></source> | ||
| </video> | ||
| <p aria-hidden="true">The above video shows a giant fat rabbit climbing out of a hole in the ground. | ||
| He stretches, yaws, and then starts walking. | ||
| Then he stops to scratch his bottom.</p> | ||
| </html> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
This collides with the changes made in #2064.
There was a problem hiding this comment.
Thanks for catching that. Requested more details in #2186
There was a problem hiding this comment.
This PR is removing "included in the accessibility tree" from the expectation. This will be a passed example since a transcript is available.
There was a problem hiding this comment.
This PR is the correct direction. We remove the change from 2064. AG decided that transcripts aren't strictly required to be visible.
giacomo-petri
added
On hold
Blocked
WilcoFiers
approved these changes
Aug 29, 2024
Comment on lines
+151
to
+164
| #### Failed Example 3 | ||
| This `video` element has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][]. | ||
| ```html | ||
| <html lang="en"> | ||
| <video controls> | ||
| <source src="/test-assets/rabbit-video/video.mp4" type="video/mp4"></source> | ||
| <source src="/test-assets/rabbit-video/video.webm" type="video/webm"></source> | ||
| </video> | ||
| <p aria-hidden="true">The above video shows a giant fat rabbit climbing out of a hole in the ground. | ||
| He stretches, yaws, and then starts walking. | ||
| Then he stops to scratch his bottom.</p> | ||
| </html> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
This PR is the correct direction. We remove the change from 2064. AG decided that transcripts aren't strictly required to be visible.
Comment on lines
+151
to
+153
| #### Failed Example 3 | ||
| This `video` element has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][]. | ||
| ```html |
There was a problem hiding this comment.
Suggested change
| #### Failed Example 3 | |
| This `video` element has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][]. | |
| ```html | |
| #### Failed Example 3 | |
| This `video` element has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][]. | |
| ```html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue(s): #2186
Updates:
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve