Generic enum panics on finalize

actgardner · Sep 29, 2021 · 2012511 · 2012511
1 parent 8a6c391
commit 2012511
Show file tree

Hide file tree

Showing 6 changed files with 38 additions and 38 deletions.
diff --git a/v9/generic/array.go b/v9/generic/array.go
@@ -27,10 +27,10 @@ func (r *arrayDatum) SetDouble(v float64) {}
 func (r *arrayDatum) SetBytes(v []byte) {}
 func (r *arrayDatum) SetString(v string) {}
 
-func (r *arrayDatum) Get(i int) types.Field { panic("") }
+func (r *arrayDatum) Get(i int) types.Field { panic("cannot Get on generic array") }
 func (r *arrayDatum) SetDefault(i int) {}
 
-func (r *arrayDatum) AppendMap(key string) types.Field { panic("") }
+func (r *arrayDatum) AppendMap(key string) types.Field { panic("cannot AppendMap on generic array") }
 
 func (r *arrayDatum) AppendArray() types.Field {
  d := DatumForType(r.itemType)

diff --git a/v9/generic/enum.go b/v9/generic/enum.go
@@ -20,20 +20,18 @@ func (r *enumDatum) Datum() interface{} {
  return r.value
 }
 
-func (r *enumDatum) SetBoolean(v bool) { panic("") }
+func (r *enumDatum) SetBoolean(v bool) { panic("cannot SetBoolean on generic enum") }
 func (r *enumDatum) SetInt(v int32) {
  r.value = r.symbols[v]
 }
-func (r *enumDatum) SetLong(v int64) {
- panic("")
-}
-func (r *enumDatum) SetFloat(v float32) { panic("") }
-func (r *enumDatum) SetDouble(v float64) { panic("") }
-func (r *enumDatum) SetBytes(v []byte) { panic("") }
-func (r *enumDatum) SetString(v string) { panic("") }
-func (r *enumDatum) Get(i int) types.Field { panic("") }
+func (r *enumDatum) SetLong(v int64) { panic("cannot SetLong on generic enum") }
+func (r *enumDatum) SetFloat(v float32) { panic("cannot SetFloat on generic enum") }
+func (r *enumDatum) SetDouble(v float64) { panic("cannot SetDouble on generic enum") }
+func (r *enumDatum) SetBytes(v []byte) { panic("cannot SetBytes on generic enum") }
+func (r *enumDatum) SetString(v string) { panic("cannot SetString on generic enum") }
+func (r *enumDatum) Get(i int) types.Field { panic("cannot Get on generic enum") }
 func (r *enumDatum) SetDefault(i int) {}
-func (r *enumDatum) AppendMap(key string) types.Field { panic("") }
-func (r *enumDatum) AppendArray() types.Field { panic("") }
-func (r *enumDatum) NullField(t int) { panic("") }
-func (r *enumDatum) Finalize() { panic("") }
+func (r *enumDatum) AppendMap(key string) types.Field { panic("cannot AppendMap on generic enum") }
+func (r *enumDatum) AppendArray() types.Field { panic("cannot AppendArray on generic enum") }
+func (r *enumDatum) NullField(t int) { panic("cannot NullField on generic enum") }
+func (r *enumDatum) Finalize() {}
diff --git a/v9/generic/map.go b/v9/generic/map.go
@@ -27,7 +27,7 @@ func (r *mapDatum) SetDouble(v float64) {}
 func (r *mapDatum) SetBytes(v []byte) {}
 func (r *mapDatum) SetString(v string) {}
 
-func (r *mapDatum) Get(i int) types.Field { panic("") }
+func (r *mapDatum) Get(i int) types.Field { panic("cannot Get on generic map") }
 func (r *mapDatum) SetDefault(i int) {}
 
 func (r *mapDatum) AppendMap(key string) types.Field {
@@ -39,7 +39,7 @@ func (r *mapDatum) AppendMap(key string) types.Field {
  return d
 }
 
-func (r *mapDatum) AppendArray() types.Field { panic("") }
+func (r *mapDatum) AppendArray() types.Field { panic("cannot AppendArray on generic map") }
 
 func (r *mapDatum) NullField(t int) {}
 func (r *mapDatum) Finalize() {}
diff --git a/v9/generic/primitive.go b/v9/generic/primitive.go
@@ -34,12 +34,14 @@ func (r *primitiveDatum) SetBytes(v []byte) {
 func (r *primitiveDatum) SetString(v string) {
  r.value = v
 }
-func (r *primitiveDatum) Get(i int) types.Field { panic("") }
+func (r *primitiveDatum) Get(i int) types.Field { panic("cannot Get on generic datum") }
 func (r *primitiveDatum) SetDefault(i int) {}
 
-func (r *primitiveDatum) AppendMap(key string) types.Field { panic("") }
+func (r *primitiveDatum) AppendMap(key string) types.Field {
+ panic("cannot AppendMap on generic datum")
+}
 
-func (r *primitiveDatum) AppendArray() types.Field { panic("") }
+func (r *primitiveDatum) AppendArray() types.Field { panic("cannot AppendArray on generic datum") }
 
 func (r *primitiveDatum) NullField(t int) {}
 func (r *primitiveDatum) Finalize() {}
diff --git a/v9/generic/record.go b/v9/generic/record.go
@@ -25,13 +25,13 @@ func (r *recordDatum) Datum() interface{} {
  return m
 }
 
-func (r *recordDatum) SetBoolean(v bool) { panic("") }
-func (r *recordDatum) SetInt(v int32) { panic("") }
-func (r *recordDatum) SetLong(v int64) { panic("") }
-func (r *recordDatum) SetFloat(v float32) { panic("") }
-func (r *recordDatum) SetDouble(v float64) { panic("") }
-func (r *recordDatum) SetBytes(v []byte) { panic("") }
-func (r *recordDatum) SetString(v string) { panic("") }
+func (r *recordDatum) SetBoolean(v bool) { panic("cannot SetBoolean on generic record") }
+func (r *recordDatum) SetInt(v int32) { panic("cannot SetInt on generic record") }
+func (r *recordDatum) SetLong(v int64) { panic("cannot SetLong on generic record") }
+func (r *recordDatum) SetFloat(v float32) { panic("cannot SetFloat on generic record") }
+func (r *recordDatum) SetDouble(v float64) { panic("cannot SetDouble on generic record") }
+func (r *recordDatum) SetBytes(v []byte) { panic("cannot SetBytes on generic record") }
+func (r *recordDatum) SetString(v string) { panic("cannot SetString on generic record") }
 func (r *recordDatum) Get(i int) types.Field {
  field := r.def.Fields()[i]
  r.fields[i] = DatumForType(field.Type())
@@ -41,8 +41,8 @@ func (r *recordDatum) SetDefault(i int) {
  field := r.def.Fields()[i]
  r.fields[i] = &primitiveDatum{field.Default()}
 }
-func (r *recordDatum) AppendMap(key string) types.Field { panic("") }
-func (r *recordDatum) AppendArray() types.Field { panic("") }
+func (r *recordDatum) AppendMap(key string) types.Field { panic("cannot AppendMap on generic record") }
+func (r *recordDatum) AppendArray() types.Field { panic("cannot AppendArray on generic record") }
 func (r *recordDatum) NullField(t int) {
  r.fields[t] = &primitiveDatum{nil}
 }

diff --git a/v9/generic/union.go b/v9/generic/union.go
@@ -14,19 +14,19 @@ func (r *unionDatum) Datum() interface{} {
  return r.datum.Datum()
 }
 
-func (r *unionDatum) SetBoolean(v bool) { panic("") }
-func (r *unionDatum) SetInt(v int32) { panic("") }
+func (r *unionDatum) SetBoolean(v bool) { panic("cannot SetBoolean on generic union") }
+func (r *unionDatum) SetInt(v int32) { panic("cannot SetInt on generic union") }
 func (r *unionDatum) SetLong(v int64) {}
-func (r *unionDatum) SetFloat(v float32) { panic("") }
-func (r *unionDatum) SetDouble(v float64) { panic("") }
-func (r *unionDatum) SetBytes(v []byte) { panic("") }
-func (r *unionDatum) SetString(v string) { panic("") }
+func (r *unionDatum) SetFloat(v float32) { panic("cannot SetFloat on generic union") }
+func (r *unionDatum) SetDouble(v float64) { panic("cannot SetDouble on generic union") }
+func (r *unionDatum) SetBytes(v []byte) { panic("cannot SetBytes on generic union") }
+func (r *unionDatum) SetString(v string) { panic("cannot SetString on generic union") }
 func (r *unionDatum) Get(i int) types.Field {
  r.datum = DatumForType(r.itemTypes[i])
  return r.datum
 }
 func (r *unionDatum) SetDefault(i int) {}
-func (r *unionDatum) AppendMap(key string) types.Field { panic("") }
-func (r *unionDatum) AppendArray() types.Field { panic("") }
-func (r *unionDatum) NullField(t int) { panic("") }
+func (r *unionDatum) AppendMap(key string) types.Field { panic("cannot AppendMap on generic union") }
+func (r *unionDatum) AppendArray() types.Field { panic("cannot AppendArray on generic union") }
+func (r *unionDatum) NullField(t int) { panic("cannot NullField on generic union") }
 func (r *unionDatum) Finalize() {}