#193: MarshalJSON preserves avro schema ordering #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#193
Since avro field order is important, and json.Marshal doesn't preserve the same ordering as struct has, I added this approach (which does generate a fair amount of code) but seems to be working.
I would add the test case for this but not sure since I am not that much into the codebase.
I did however test it locally.
And this way if we have a struct like
fields{ A: "a", C: "c", D: "d", B: "b", Z: "z", E: "e", }
The order would always be after marshaling:
{"a":"a","c":"c","d":"d","b":"b","z":"z","e":"e"}
Edit: now to think about it maybe the template should only call json.Marshal and since it's a struct it should be fine.