sudo and pty migration issues #729
Comments
|
Have the same problem, but it occurs only when using |
|
Can confirm the same issue. I ran Thanks, and do let me know if there's anything else I can do to help troubleshoot this. |
The terminal I use is "urxvt" |
|
Also happens with "foot" terminal. And terminal is stuck after asking a second time to "Proceed with installation". |
|
I got the same using kitty, I press Enter to confirm, then Enter again to reinstall failed package, then it works. |
|
Same is happening to me on Konsole. |
|
This might sound a bit off-topic, but has anyone noticed that colours have stopped working in the pager "most" as well? Just thought I'd ask in case there's something deeper wrong with Arch's environment now (and this issue is not pikaur actually doing something wrong). Cheers. |
|
Found out what's up with pikaur anyway, it's to do with the new version of sudo. Downgrading from 1.9.14.p1-1 back to 1.9.13.p3-1 and there's no display issue. |
|
Fix here: https://bugs.archlinux.org/task/79088
|
|
Thanks for reporting! |
now it should work normally with default |
|
1.16-1 seems to be broken. It runs sudo unnecessarily now and you can't hit enter on the sudo prompt. |
Latest pikaur runs fine here with current sudo -without the fix. |
|
Hmm, not for me.. Latest sudo and pikaur without the pty workaround: It prompts correctly for sudo on the first go, but then prompts again and the input isn't handled properly, have to ^C to get out of it. |
|
@cg00001 I'm guessing you have a config that allows your user or group to sudo without a password? I do not see the issue if I configure sudo to allow me with NOPASSWD. |
|
With the latest version (1.16) the output is not distorted anymore, but the sudo prompt seems to block. Then it seems to be blocked. Return does not have any effect. Need to Ctrl+C to get out of it. |
|
thanks for more info - i'll check it further today |
actionless
changed the title
|
As a quick, hacky workaround until this is fixed, you can temporarily set NOPASSWD for your user or group and do updates. |
Thank you so much for your efforts! |
|
Tested latest git master, this lets you enter at the prompt now, but if I've already sudo'ed recently I still get prompted for a password the second time. Is this pikaur or sudo causing this? Edit: this has to be pikaur, I can repeatedly run sudo commands after an initial password entry. |
|
yeah, it seems to be a side-effect of new pty-based design of pikspect module - each pacman command is running inside its own virtual terminal - so it's basically behaving like if you'd be running pacman commands in separate terminals - this require designing new SudoLoop, which would be acting as sudo-ed process which would be spawing all next processes from itself without sudo-ing |
|
Many thanks for re-opening this, yet again, in order to solve this. Love your work, pikaur is the best AUR helper out there. |
Yes. |
|
i myself have nopasswd for pacman executable configured - so i didn't noticed the problem at first place |
|
NOPASSWD just on pacman is an ok workaround for this actually. But the old behaviour is more desirable (sudo with password if you need to, then everything else follows). |
|
Re-installing pikaur from scratch solved the problem for me. |
|
also, instead of implementing new sort of sudo loop
the good thing about going with this solution - that it would require the minimal amount of code (and potential new bugs) - since it will be mostly re-using existing code for systemd DynamicUsers support |
|
also, for network requests, i think might be useful to spawn a thread running with os.setuid to that original user id as well not like urgent but would be nice to have |
|
pass user-id and config-path as arguments when sudo-ing pikaur, as a bonus that would make those cli flags available to use manually as well, for example to have specific user dedicated to only run pikaur (and to add user-id option to config as well) |
|
please do some testing before i'll do the release |
|
warning - if you had |
now i also [optionally] returned that behavior with the new config option: |
|
Tested latest master here, and everything is working as it did before. Using latest sudo, no changes to my pikaur config and no !pty workaround. One thing to keep an eye on which was mentioned in the Arch bug, is that sudo made a fix as well, so not sure how this will affect pikaur once the new version comes out, will have to wait and see. sudo-project/sudo#258 (comment) Thanks again @actionless |
|
Found an additional issue now, something to do with running as root. Unable to build because of how directories are being created (this is using latest master): |
|
thanks @pezz , i'll look into it now |
|
please check if it works for you |
|
(you'll have to remove or chown those directories which got created with wrong permissions) |
|
Using 1.17 as released on the AUR and things are looking good. |
|
1.17 works provided that sudo has been upgraded to the latest version. |
|
When pressing enter (aka carriage return) didn't work, did anyone try hitting Turning off That includes To get the sudo to accept the input line, you need to send an actual newline byte. Newline is ASCII code 10, so you need to press (To add to the confusion, many keyboards label this key |
|
@kurahaupo i don't think anyone would be able to reproduce this issue, as those regressions were very specific to refactoring of sub pty implementation (i.e. of tmux-like wrapper for controlling the output of commands spawned by pikaur) |
Description:
When running
pikaur -Syuthe output after "Starting full AUR upgrade..." is shifted heavily, probably due to wrong insertion of spaces or tabs, making it very hard to read/understand what is happening: Screenshot.When choosing the "m" option, the package list is cleanly shown and it is possible to install the packages. Sometimes (although not always reproducable) the final confirmation question before installing seems to block the progress and hangs without further output.
Attached log:
Seems to work as intended:
If there is any further information you may require, please let me know.
Thanks a lot for your support!
The text was updated successfully, but these errors were encountered: