Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Message Format #3

Closed
erictaylor opened this issue Mar 25, 2021 · 3 comments
Closed

Commit Message Format #3

erictaylor opened this issue Mar 25, 2021 · 3 comments

Comments

@erictaylor
Copy link
Contributor

Commit message are coming out as "{Whatever message is provided}".

Suspect https://github.com/actions-js/push/blob/master/start.sh#L52 needs changed to "${INPUT_MESSAGE}" from "{$INPUT_MESSAGE}".
@erictaylor erictaylor mentioned this issue Mar 25, 2021
Merged
@erictaylor
Copy link
Contributor Author

PR #4

@bconnorwhite
Copy link

Bump

@notfilippo
Copy link
Contributor

Finally merged 🎉 !

coreymckrill added a commit to WordPress/Learn that referenced this issue Aug 2, 2021
@coreymckrill
Tooling: Update the version of the Push action for the i18n workflow
9946a1b 
The commit hash we have been pinning for this action had a bug that
caused the commit message to be wrapped in curly brackets. This new
commit hash is a new version release that includes a fix for that and
one other issue (I reviewed all the changes).

See actions-js/push#3
coreymckrill added a commit to WordPress/pattern-directory that referenced this issue Aug 2, 2021
@coreymckrill
Tooling: Update the version of the Push action for the i18n workflow
1d78c28 
The commit hash we have been pinning for this action had a bug that
caused the commit message to be wrapped in curly brackets. This new
commit hash is a new version release that includes a fix for that and
one other issue (I reviewed all the changes).

See actions-js/push#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erictaylor @notfilippo @bconnorwhite