Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up release-runners.yaml #3

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

ddelange
Copy link
Contributor

@ddelange ddelange commented Jan 17, 2023

Hi 👋

  • Use cache-to: type=inline (docs), to avoid hitting GH cache size limits (possible since there is no multi-stage image building here)
  • Use pull: true, to avoid eternally caching ubuntu:20.04 etc which might receive security patches upstream
  • Squash latest builds into the same build step

total duration before (gha cache): 11m 28s
total duration after (this commit): 58s

@ddelange
Copy link
Contributor Author

@Link- spam? ^

@Link-
Copy link
Contributor

Link- commented Jan 23, 2023

Thank you @ddelange for your contribution - we're a bit swamped at the moment preparing the new mode. Allow me some time before reviewing and testing this change.

@Link- Link- requested a review from toast-gear January 23, 2023 13:48
@Link-
Copy link
Contributor

Link- commented Jan 23, 2023

@toast-gear since you were the original author of the build steps, could you also kindly share your thoughts on this?

hoping it gets fixed upstream ref docker/buildx#1509 (comment)
@ddelange
Copy link
Contributor Author

no worries! it helped speed up development/debugging of actions/actions-runner-controller#2015 so I thought I'd also add it here :)

Copy link
Contributor

@toast-gear toast-gear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work

@Link- Link- self-assigned this Jan 24, 2023
Copy link
Contributor

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work

@Link- Link- merged commit e96d441 into actions-runner-controller:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants