Skip to content

Commit

Permalink
ci: don't login on a pr (#1554)
Browse files Browse the repository at this point in the history
* ci: don't login on a pr

Co-authored-by: toast-gear <toast-gear@users.noreply.github.com>
  • Loading branch information
toast-gear and toast-gear authored Jun 22, 2022
1 parent 667764e commit 23f091d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/actions/setup-docker-environment/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@ runs:
version: latest

- name: Login to DockerHub
if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' }}
uses: docker/login-action@v2
with:
username: ${{ inputs.username }}
password: ${{ inputs.password }}

- name: Login to GitHub Container Registry
if: ${{ github.event_name == 'release' || github.event_name == 'push' && github.ref == 'refs/heads/master' }}
uses: docker/login-action@v2
with:
registry: ghcr.io
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/runners.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
context: ./runner
file: ./runner/${{ matrix.name }}.dockerfile
platforms: linux/amd64,linux/arm64
push: ${{ github.ref == 'master' && github.event.pull_request.merged == true }}
push: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
build-args: |
RUNNER_VERSION=${{ env.RUNNER_VERSION }}
DOCKER_VERSION=${{ env.DOCKER_VERSION }}
Expand Down

0 comments on commit 23f091d

Please sign in to comment.