Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the --sync-period default from 10m to 1m #1294

Closed
toast-gear opened this issue Mar 31, 2022 · 0 comments · Fixed by #1308
Closed

Change the --sync-period default from 10m to 1m #1294

toast-gear opened this issue Mar 31, 2022 · 0 comments · Fixed by #1308
Labels
refactor
Milestone
v0.23.0

Comments

@toast-gear
Copy link
Collaborator

toast-gear commented Mar 31, 2022 •
edited
Loading

Now that we are caching API calls #1210 we should change the sync period default from 10m to 1m as this is a better balance between performance and the "out of the box" risk of unintentional rate limited
@toast-gear toast-gear added this to the v0.23.0 milestone Apr 6, 2022
@toast-gear toast-gear mentioned this issue Apr 6, 2022
Merged
mumoshu added a commit that referenced this issue Apr 24, 2022
@toast-gear @mumoshu
refactor: set sync period default to 1m (#1308)
c3e280e 
Fixes: #1294

Co-authored-by: toast-gear <toast-gear@users.noreply.github.com>
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
@mumoshu mumoshu mentioned this issue Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging a pull request may close this issue.

refactor: set sync period default to 1m actions/actions-runner-controller
1 participant
@toast-gear