-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller looks like trying to delete PV not belongs to him #1511
Comments
This reproduces for me even if I set |
I also have the same issue, it's trying to delete a PVC that is from a non-related namespace. |
Hey everyone. In short, it's not trying to delete any resource. It's just a debug message to let you know that ARC did recognize the PV and still waiting to decide whether it needs to reconcile the PV or not (and it finally reconciles the PV only when the PV was created by ARC). See the relevant code linked below- you'll see it will never be removed, and will never modify unrelated PV. |
I believe this isn't actually a bug like reported(Feel free to retag it as "bug" if you still think so!). However I'm still open to suggestions like... should we rephrase the log message in a way so that it's less confusing, or hide it behind a more verbose log level so that it doesn't show up by default(btw, the default log level is DEBUG in ARC's official chart so that might be the reason why many folks are seeing it). |
@mumoshu Out of curiosity, why the pv reconciler even recognizes PV that do not belong to its namespace? (a case where the controller is configured with |
@rjeczalik AFAIK, PVs are not namespaced. Perhaps I'm missing something and you might be successfully using PVs with namespaces? |
@mumoshu Right, you're correct. Thanks for the explanation 🤗 |
@mumoshu rephrasing the log message would be great as it currently suggests that it either gets removed by ARC, or I should manually remove those PVCs, while neither is true. |
@mumoshu much better, thank you! |
Closing as resolved. Please feel free to open another issue if necessary! Thanks |
Controller Version
0.24.0
Helm Chart Version
0.19.0
Deployment Method
Helm
Checks
Resource Definitions
I don't have any resources set yet, just finished installing the controller.
To Reproduce
Describe the bug
When installing fresh controller, without any runners attached, it finds used PV in the cluster, and tries to delete it.
Describe the expected behavior
The controller should not touch PVs not belongs to him.
Controller Logs
Runner Pod Logs
Additional Context
No response
The text was updated successfully, but these errors were encountered: