Manifests valid for K8s 1.18 and 1.19 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hi-Fi Thanks for the fix! I'm still catching up - once kubernetes-sigs/controller-tools#480 is released, we can revert this and bump controller-tools instead to fix the manifests, right? |
|
According comments kubernetes-sigs/controller-tools#480 has still some issues (default added only to beta, that is not supporting it). But this is temporary fix before real one to get working manifests . I think that with real fox apiVersion should be pushed to v1 which causes more changes to tests, too. |
Hi-Fi
force-pushed
the
fix_kube_118_119
branch
from
15f4476 to
1dc1179
Compare
This was referenced Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113
Fixes #116