ci: align pipeline files and setups #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mumoshu this is good to review, probably worth doing the v0.24.0 release first before this is merged (assuming no changes needed) |
|
Added a scope to the cache so we get layer caching for both runner images. This was based on this issue moby/buildkit#2885 EDIT seems to work testing by re-running the pipeline after a green build, both runner jobs pull from cache successfully |
crazy-max
reviewed
May 30, 2022
mumoshu
reviewed
Jun 7, 2022
mumoshu
reviewed
Jun 7, 2022
mumoshu
approved these changes
Jun 8, 2022
cablespaghetti
pushed a commit
to cablespaghetti/actions-runner-controller
that referenced
this pull request
Jun 22, 2022
* ci: align pipeline files and setups * ci: more changes * ci: various changes * ci: fix setup-helm action ref * ci: better pipeline name * ci: more format aligning * ci: more format aligning * ci: better job name * ci: supports multiple languages * ci: better pipeline and job names * ci: do a verb-noun thing for consistency * ci: use 'arc' when talking holistically * ci: add caching scope * ci: put canary in a scope * ci: fix syntax error * ci: better pipeline and job names * ci: better job name Co-authored-by: toast-gear <toast-gear@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this should be merged with
[skip ci]and the status check will need adjusting post merge, I guess technically we should probably expect the result (Code scanning results / CodeQL Successful in 3s — No new or fixed alerts) rather than the pipeline run itself