ci: add GitHub packages to arc release #1525
Conversation
| @@ -58,6 +58,9 @@ jobs: | |||
| ${{ env.DOCKERHUB_USERNAME }}/actions-runner-controller:latest | |||
| ${{ env.DOCKERHUB_USERNAME }}/actions-runner-controller:${{ env.VERSION }} | |||
| ${{ env.DOCKERHUB_USERNAME }}/actions-runner-controller:${{ env.VERSION }}-${{ steps.vars.outputs.sha_short }} | |||
| ghcr.io/actions-runner-controller/actions-runner-controller:latest | |||
| ghcr.io/actions-runner-controller/actions-runner-controller:${{ env.VERSION }} | |||
| ghcr.io/actions-runner-controller/actions-runner-controller:${{ env.VERSION }}-${{ steps.vars.outputs.sha_short }} | |||
There was a problem hiding this comment.
I guess we might also need the permission for package writing at least, as similar as we do for the canary builds (#1524):
There was a problem hiding this comment.
we don't have any exlicit permissions set at the moment so the token will be write all. I'll do a little test to figure out which we need and add them to his PR as we do more than the canary workflow so may need other permissions
There was a problem hiding this comment.
Added what I think we need based on the API routes in https://docs.github.com/en/rest/overview/permissions-required-for-github-apps
| @@ -5,6 +5,11 @@ on: | |||
| types: | |||
| - published | |||
|
|
|||
| # https://docs.github.com/en/rest/overview/permissions-required-for-github-apps | |||
| permissions: | |||
| contents: write | |||
There was a problem hiding this comment.
| contents: write | |
| contents: read |
Perhaps read might be enough as our canary pipeline seems to be working fine with read? (I wonder if we need write for cache writing but apparently not?
No description provided.