Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set restart policy on the runner pod to Never if restartPolicy is not set in template #2787

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Set restart policy on the runner pod to Never if restartPolicy is not set in template #2787

merged 1 commit into from
Sep 7, 2023

Conversation

nikola-jokic
Copy link
Collaborator

Fixes #2782

@nikola-jokic nikola-jokic requested review from mumoshu, toast-gear and a team as code owners July 31, 2023 11:16
@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Jul 31, 2023
@nikola-jokic nikola-jokic added this to the gha-runner-scale-set-0.5.1 milestone Aug 21, 2023
@Link- Link- modified the milestones: gha-runner-scale-set-0.5.1, gha-runner-scale-set-0.6.0 Sep 7, 2023
Link-
Link- approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this

@Link- Link- merged commit 10d7934 into master Sep 7, 2023
@Link- Link- deleted the nikola-jokic/runner-restart-policy branch September 7, 2023 11:39
@nikola-jokic nikola-jokic mentioned this pull request Sep 15, 2023
Merged
@nikola-jokic nikola-jokic restored the nikola-jokic/runner-restart-policy branch September 26, 2023 09:52
@nikola-jokic nikola-jokic deleted the nikola-jokic/runner-restart-policy branch September 26, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Link- Link- Link- approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

Assignees
No one assigned
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Milestone
gha-runner-scale-set-0.6.0
Development

Successfully merging this pull request may close these issues.

Pod becomes CrashLoopBackOff after runner finished
2 participants
@nikola-jokic @Link-