-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Allow events events api #3507
Conversation
dennybaa
commented
May 8, 2024
•
edited
Loading
edited
Hey @dennybaa, I'm not sure why would you need event permission for the gha-runner-scale-set? There is no gha-runner-scale-set controller that emits events. |
@nikola-jokic Hello. That's very odd. Because I've gotten this error message, after I've added the above changes it's disappeared. This is output from its logs 😕 I can only admit, that somehow during errors with the application there was something that made actually the pod emit events... In this case the issue is not legit. |
Maybe something went wrong with the installation 😕 |
@nikola-jokic Maybe you've got any ides?
|
It's been just working, and now again... |
It doesn't complain after:
|
More details, maybe these events are generated automatically during crash I don't know
|
Noop, I can confirm, doesn't matter if it crashes or not plz reopen @nikola-jokic the issue is out there |
Hey @dennybaa, I was able to reproduce this issue when CRDs are introduced after the installation. There is no need and to be honest, I wouldn't want to add events permission when we normally don't need it. The expectation is that you have CRDs installed before the controller. That is likely why some of the installations you made were successful without this error. |
@nikola-jokic Thanks a lot for the feedback! Less permissions better :) This one in fact doesn't bother me much. But one small question, I've got it all running on spot instances generally everything works fine. But from time to time once in a while (let's say 2 month) scale set completely disappears (i believe i'm running with the debug off, so no details, only reinstall of the scale set and possibly restart of the controller (maybe reinstall, don't remeber) brings things back to life :( Is there any relevant issue or maybe you are aware of? |