Skip to content

Commit

Permalink
Update default runtime to node20 (#1436)
Browse files Browse the repository at this point in the history 
* .

* update workflows
  • Loading branch information
@takost
takost authored Aug 29, 2023
1 parent f43a0e5 commit 97a652b
Show file tree
Hide file tree
Showing 5 changed files with 9,162 additions and 25,063 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-dist.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Set Node.js 16.x

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

16
- name: Set Node.js 20.x

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

20
uses: actions/setup-node@v1
with:
node-version: 16.x

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

16
node-version: 20.x

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

20

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/setup-node@v1
with:
node-version: 16.x

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

16
node-version: 20.x

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

20
- uses: actions/checkout@v3
- run: npm ci
- run: npm run build
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,6 @@ inputs:
description: The base URL for the GitHub instance that you are trying to clone from, will use environment defaults to fetch from the same instance that the workflow is running from unless specified. Example URLs are https://github.com or https://my-ghes-server.example.com
required: false
runs:
using: node16

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

node16
using: node20

This comment has been minimized.

Sign in to view

Copy link
@KolomboPulse

KolomboPulse Oct 3, 2024

node20
main: dist/index.js
post: dist/index.js
Loading

9 comments on commit 97a652b

@jonathan-telnyx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takost this change is breaking our builds with the error

Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load actions/checkout/master/action.yml

any suggestion on how to fix it?

@denpolischuk
Copy link

@denpolischuk denpolischuk commented on 97a652b Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here
@jonathan-telnyx I'd suggest to reference earlier stable version instead of master like so

      - name: Checkout
        uses: actions/checkout@v3

@Brion-Rogers
Copy link

@Brion-Rogers Brion-Rogers commented on 97a652b Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks on Amazon Linux 2 (AL2) because it doesn't ship with the correct versions of glibc:

/opt/actions-runner/externals/node20/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /opt/actions-runner/externals/node20/bin/node)

from latest available AMI with name="amzn2-ami-hvm-*-x86_64-gp2"

testing with Amazon Linux 2023 and will post update here for others

@cliffchapmanrbx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Brion-Rogers, we had several folks on our GitHub Enterprise Server get surprised by this and we're actively migrating them to use the @v3 tag instead of @master.

@homer6
Copy link

@homer6 homer6 commented on 97a652b Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking our builds. The jump from 16 to 20 is too aggressive. Please hit 18 first.

https://nodejs.dev/en/about/releases/

@Maaajjssj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#@

@088103
Copy link

@088103 088103 commented on 97a652b Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Brion-Rogers, we had several folks on our GitHub Enterprise Server get surprised by this and we're actively migrating them to use the @v3 tag instead of @master.

@088103
Copy link

@088103 088103 commented on 97a652b Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takost this change is breaking our builds with the error

Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load actions/checkout/master/action.yml

any suggestion on how to fix it?

@alnaimi-github
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  - name: Checkout
    uses: actions/checkout@v3

Please sign in to comment.