Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 no longer downloads tags #100

Closed
charliebruce opened this issue Dec 9, 2019 · 2 comments · Fixed by #112
Closed

v2 no longer downloads tags #100

charliebruce opened this issue Dec 9, 2019 · 2 comments · Fixed by #112
Assignees
@ericsciple
Labels
documentation Improvements or additions to documentation

Comments

@charliebruce
Copy link

As of v2, tags are no longer available in the cloned repository, whereas previously tags would have been visible. I was caught out by this, as I was referencing this Action by @master rather than @v1.

Worth mentioning somewhere in the changelog?
@ericsciple
Copy link
Contributor

ericsciple commented Dec 10, 2019 •
edited
Loading

i'll update the scenarios in the readme. v2 perf was optimized for the mainline scenario, and only fetches a single commit

@ericsciple ericsciple self-assigned this Dec 10, 2019
@ericsciple ericsciple added the documentation Improvements or additions to documentation label Dec 10, 2019
@PaulHatch PaulHatch mentioned this issue Dec 12, 2019
Closed
This was referenced Dec 13, 2019
Closed
Merged
@gitfool
Copy link

gitfool commented Dec 28, 2019 •
edited
Loading

Rather than now requiring a separate run command to fetch tags, it would be much nicer to have a fetch-tags option. Default to false to preserve new behaviour, passing --no-tags, otherwise pass --tags when true.

@gitfool gitfool mentioned this issue Dec 28, 2019
Closed
@jasonkarns jasonkarns mentioned this issue Mar 31, 2020
Closed
simu added a commit to daiboruta/commodore that referenced this issue Jun 15, 2020
@simu
Explictly fetch whole history when building Docker image
d17b533 
Otherwise, actions/checkout@v2 will only fetch the latest commit,
leaving `git describe` unable to produce a useful version, cf.
actions/checkout#100 and
actions/checkout#217
simu added a commit to daiboruta/commodore that referenced this issue Jun 15, 2020
@simu
Explictly fetch the whole Git history when building Docker image for PR
8a6c574 
Otherwise, `actions/checkout@v2` will only fetch the latest commit,
leaving `git describe` unable to produce a useful version, cf.
actions/checkout#100 and
actions/checkout#217

Also switch to `actions/checkout@v2` when building the master branch and
release Docker images.
simu added a commit to daiboruta/commodore that referenced this issue Jun 15, 2020
@simu
Explictly fetch the whole Git history when building Docker image for PR
2e2d4c1 
Otherwise, `actions/checkout@v2` will only fetch the latest commit,
leaving `git describe` unable to produce a useful version, cf.
actions/checkout#100 and
actions/checkout#217

Also switch to `actions/checkout@v2` when building the master branch and
release Docker images.
simu added a commit to daiboruta/commodore that referenced this issue Jun 15, 2020
@simu
Explictly fetch the whole Git history when building Docker image for PR
41da692 
Otherwise, `actions/checkout@v2` will only fetch the latest commit,
leaving `git describe` unable to produce a useful version, cf.
actions/checkout#100 and
actions/checkout#217

Also switch to `actions/checkout@v2` when building the master branch and
release Docker images.
srueg pushed a commit to daiboruta/commodore that referenced this issue Jun 22, 2020
@simu @srueg
Explictly fetch the whole Git history when building Docker image for PR
7d3b761 
Otherwise, `actions/checkout@v2` will only fetch the latest commit,
leaving `git describe` unable to produce a useful version, cf.
actions/checkout#100 and
actions/checkout#217

Also switch to `actions/checkout@v2` when building the master branch and
release Docker images.
@ddelange ddelange mentioned this issue Sep 24, 2020
Closed
ohsh6o pushed a commit to ohsh6o/skyrim-schematron-tutorial that referenced this issue Oct 22, 2020
@aj-stein-gsa
Workaround for actions/checkout#100.
07a9989
horizon-blue added a commit to horizon-blue/pplbench that referenced this issue Nov 3, 2020
@horizon-blue @facebook-github-bot
Fix a condition check on PyPI release workflow
2b375db 
Summary:
1. There was a small bug in the PyPI release workflow where I accidentally inverted the true/false condition on whether a new version should be released or not.
2. However, (1) means that the workflow should've been triggered. The only reason it wasn't is that, by default, the `checkout` action only pull the latest commit without any history... [so using `git tag` in workflow does not return anything](actions/checkout#100)
3. To fix (2), we should use `git ls-remote` to check the existing tags on GitHub (instead of listing the local ones). Cloning the repo with full history also works, but is much less efficient.

Differential Revision: D24696408

fbshipit-source-id: 40b28124ccbb412fceb0da8784c888e88dc51f2e
@horizon-blue horizon-blue mentioned this issue Nov 3, 2020
Closed
facebook-github-bot pushed a commit to facebookresearch/pplbench that referenced this issue Nov 3, 2020
@horizon-blue @facebook-github-bot
Fix a condition check on PyPI release workflow (#52)
44b0632 
Summary:
Pull Request resolved: #52

1. There was a small bug in the PyPI release workflow where I accidentally inverted the true/false condition on whether a new version should be released or not.
2. However, (1) means that the workflow should've been triggered. The only reason it wasn't is that, by default, the `checkout` action only pull the latest commit without any history... [so using `git tag` in workflow does not return anything](actions/checkout#100)
3. To fix (2), we should use `git ls-remote` to check the existing tags on GitHub (instead of listing the local ones). Cloning the repo with full history also works, but is much less efficient.

Reviewed By: nimar

Differential Revision: D24696408

fbshipit-source-id: f0834187672acf28eabd06466b519405f487fc52
@feynmanliang feynmanliang mentioned this issue May 14, 2021
Closed
facebook-github-bot pushed a commit to facebookincubator/flowtorch that referenced this issue May 14, 2021
@facebook-github-bot
Fetch tags in gh action release workflow (#33)
4c4a038 
Summary:
### Motivation

We are bitten by actions/checkout#100 [yet again](facebookresearch/pplbench#52), so lets just fetch the tags during checkout.

### Changes proposed

Fetch tags during `actions/checkout`

Pull Request resolved: #33

Test Plan: https://github.com/facebookincubator/flowtorch/runs/2586537945?check_suite_focus=true

Reviewed By: jpchen, horizon-blue

Differential Revision: D28449241

Pulled By: feynmanliang

fbshipit-source-id: bf7224961a28fc7b2fd1e4733e519be6e0030590
meithecatte added a commit to meithecatte/miniforth that referenced this issue Sep 28, 2021
@meithecatte
Fetch tags during CI
feff798 
See actions/checkout#100
@eunjae-lee eunjae-lee mentioned this issue Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsciple ericsciple

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add more scenarios actions/checkout
3 participants
@gitfool @charliebruce @ericsciple