Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal: unsafe repository (REPO is owned by someone else) with ubuntu 20.04 container #760

Closed
wez opened this issue Apr 13, 2022 · 97 comments · Fixed by #762 or use-ink/contracts-ui#285

Comments

@wez
Copy link

wez commented Apr 13, 2022

Hello!

This started happening recently; I see it both with v2.4.0 and v.3.0.0:

Syncing repository: wez/wezterm
Getting Git version info
Deleting the contents of '/__w/wezterm/wezterm'
Initializing the repository
  /usr/bin/git init /__w/wezterm/wezterm
  Initialized empty Git repository in /__w/wezterm/wezterm/.git/
  /usr/bin/git remote add origin https://github.com/wez/wezterm
  Error: fatal: unsafe repository ('/__w/wezterm/wezterm' is owned by someone else)
  To add an exception for this directory, call:
  
  	git config --global --add safe.directory /__w/wezterm/wezterm
  Error: The process '/usr/bin/git' failed with exit code 128

Is there a way to configure/advise the action how to handle this?
Is this really a problem elsewhere in the GH actions environment?

@Elsie19
Copy link

Elsie19 commented Apr 13, 2022

@cbalioglu
Copy link

I think it is related to this: https://github.blog/2022-04-12-git-security-vulnerability-announced/

@strager
Copy link

strager commented Apr 13, 2022

I worked around this issue in my repo by adding the following step before the actions/checkout step:

      - name: work around permission issue
        run: git config --global --add safe.directory /__w/quick-lint-js/quick-lint-js

(My repo is named quick-lint-js.)

wez added a commit to wez/wezterm that referenced this issue Apr 13, 2022
@wez
Copy link
Author

wez commented Apr 13, 2022

I know nothing about how this repo works, but I'm assuming that it should probably configure the safe.directory somewhere around here:

if (remove) {
// Delete the contents of the directory. Don't delete the directory itself
// since it might be the current working directory.
core.info(`Deleting the contents of '${repositoryPath}'`)
for (const file of await fs.promises.readdir(repositoryPath)) {
await io.rmRF(path.join(repositoryPath, file))
}
}

@Locietta
Copy link

Locietta commented Apr 13, 2022

This issue seems only happens for workflows based on docker container, workflows directly running on runners is not affected.

git config --global --add safe.directory /__w/REPO/REPO workaround is only available with git v2.35.2, for older git, define the GIT_CEILING_DIRECTORIES to __w instead (but this won't work on v2.35.2).

So as a workaround for git before v2.35.2, add this step before checkout:

     - name: Trust My Directory
       run: export GIT_CEILING_DIRECTORIES=/__w # only work before git v2.35.2

My trial-and-errors are at
Locietta/github-action-playground.

lejabque added a commit to CPP-KT/template-task that referenced this issue Apr 13, 2022
lejabque added a commit to CPP-KT/vector-task that referenced this issue Apr 13, 2022
@Konadu-Akwasi-Akuoko
Copy link

Hello!

This started happening recently; I see it both with v2.4.0 and v.3.0.0:

Syncing repository: wez/wezterm
Getting Git version info
Deleting the contents of '/__w/wezterm/wezterm'
Initializing the repository
  /usr/bin/git init /__w/wezterm/wezterm
  Initialized empty Git repository in /__w/wezterm/wezterm/.git/
  /usr/bin/git remote add origin https://github.com/wez/wezterm
  Error: fatal: unsafe repository ('/__w/wezterm/wezterm' is owned by someone else)
  To add an exception for this directory, call:
  
  	git config --global --add safe.directory /__w/wezterm/wezterm
  Error: The process '/usr/bin/git' failed with exit code 128

Is there a way to configure/advise the action how to handle this? Is this really a problem elsewhere in the GH actions environment?

I recently updated git and saw this error too.

I did what @strager said and it worked just fine; moved to the parent directory where .git is stored and did git config --global --add safe.directory /myProject

@alalazo
Copy link

alalazo commented Apr 13, 2022

Can anybody explain why, if the container is using a version of git < 2.35.2, we see the issue and an error message:

  To add an exception for this directory, call:
  
  	git config --global --add safe.directory /__w/spack/spack
  Error: The process '/usr/bin/git' failed with exit code 128

referencing an option that is introduced in v2.35.2 ? (If it matters in my case it's git v2.25.1 and Ubuntu 20.04)

EDIT: Leaving the reply here for the record. Ubuntu patched git on Apr 8th, so we get a breaking behavior and a security fix without any version bump.

@yoshz
Copy link

yoshz commented Apr 13, 2022

Other solution is just to make sure your container runs as the same user as actions-runner-controller.
In my case this was uid 1000.

@zefir-git
Copy link

zefir-git commented Apr 13, 2022

Not related to this repository, but I recently upgraded my Git CLI on an Ubuntu 20.04 machine and got this error when attempting to run git commands as root in a user's home directory.

git version 2.25.1

@me-and
Copy link

me-and commented Apr 13, 2022

Same issue with the Windows runners, and it is indeed because of the security fix for CVE-2022-24765.

The quick fix is to add a step before the checkout action to run git config --global --add safe.directory <path>. The better fix will be for the runners / containers / &c. to set this automatically; on the GitHub runners, at least, because they're not shared, I don't believe there's any risk of actually hitting this vulnerability.

@AMMJ93
Copy link

AMMJ93 commented Apr 13, 2022

Running git config --global --add safe.directory /github/workspace doesnt fix the issue for me, nor does export GIT_CEILING_DIRECTORIES=/__w :

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

me-and added a commit to cygporter/git that referenced this issue Apr 13, 2022
Explicitly configure Git's safe.directory to assert that it's okay to
check out the Git repository.  Works around actions/checkout#760.
@thboop
Copy link
Contributor

thboop commented Apr 13, 2022

Thanks for the report, our team is working on a fix

daniellord32 pushed a commit to daniellord32/mautic that referenced this issue Mar 20, 2023
* Stop duplicate campaign update (#10550)

* Removing building campaign members on segment member change

As this is handled by the `bin/console mautic:campaigns:upgate` command anyway and this command is mandatory for all Mautic instances. So we are just removing a duplicated functionality to save server resources and improve request times.

* CS fix

* Adding undefined property

* Test rewritten from direct form post to form get and then submit as it was failing on CI otherwise

* Optimizing the code by:

1. json_decode called only once. Used to be called twice on the same array of contact IDs
2. not calling add/removeContacts methods when not needed. There is a lot going on and it will eventually end as the segment ID array is empty.

* Removing tests for the deleted methods

* Removing failing test that belong to a future PR

* PHPSTAN fixes

* Starting the doc with notes to upgrade to M5

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* add v5 to bug reporting (#10858)

* Merge 4 to 5 (#11044)

* Edit comment

* Changed date format

* refactor(assetslist): use short date and long date with tooltip

* change redis to v5 because it is needed for symfony/mailer

* Add a migration for lead_lists table.

* Add SQL queries for migration.

* Add definition of the last_build_date field to the model.

* Fix migration.

* Fix migration.

* Implement notification in the template.

* Add a config and a form for segment settings.

* Add a template for the config.

* Fix translations

* Fix translations

* Use an actual value from the config in the template.

* Update last_built_date value when we execute mautic:segments:update command.

* Update last_built_date value when we execute mautic:segments:update command.

* Fix code style.

* Update last_built_date when we create a segment.

* Fix a bug  with built_last_date when cloning LeadList entity.

* Fix method return type.

* Fix class name.

* Fix UpdateLeadListsCommand command.

* Add a segment config type test.

* Add a config subscriber test.

* Fix pluralization.

* Add tests for LeadList entity class.

* Refactor variables names (as was suggessted here https://github.com/mautic-inc/mautic-cloud/pull/942/files#r475729087).

* Rename LeadList::updateLastBuiltDate to LeadList::setLastBuiltDateToCurrentDatetime as suggested here: https://github.com/mautic-inc/mautic-cloud/pull/942/files#r475720725

* CS fixes

* Type fixes

* PHP 7.4 syntax sugar

* Fixing a bug caused by cherry-picking discovered by unit tests (:tada:)

* Adding test for the issue found during testing

The condition for max contacts param was opposit to what we want

* Forgot to add the test

* CS fix

* Asserting also the segment member count

* Set default values for original_is_published_value and column_is_not_created columns so older migrations won't fail

* Updating migrations to M4

* Fixing comparison value for the default value

* Fix accessibility of HTML Emails

* Add unit tests

* Remove unused class reported from PHPStan

* Fix Call to a member function getLanguage() on null

* Using the subject directly without the token, more test cases

* CS fixes

* Fix default order dir in controllers

* Set orderBy to session If does not exist

* Revert back CS fixer tableheader.html.php

* First work on Composer integration

* Add Composer dependency to Mautic

* Use KernelInterface to get project directory

* Explicitly set version of mautic/core-lib to v4

* Fix CS

* WIP Marketplace UI installation

* WIP UI installer now working

* Fix removal of plugins through UI + memory issues

* Fix CS

* Changes shown at live demo MautiCon

* Fix CS

* Fix PHPSTAN

* Parse + cache allowlist from GitHub

* Refactor allowlist into its own service

* Fix DI config

* Fix failing tests

* Fix AjaxController

* Add composer.json and composer.lock to full package, but not in update package

* Add some basic error handling to cache clear in AjaxController

* Catch errors, add dry-run functionality

* Add tests

* Forgot to push dummy allowlist

* Add additional tests

* Fix PHPSTAN

* Refactor Composer service into ComposerHelper in core, add Composer update step to Mautic update

* Remove ext-imap as hard Composer requirement

* Bump composer/composer to latest version for testing

* Bump composer/composer to 2.2 for speed/memory improvements

* Lock composer/composer version to prevent issues while updating Mautic

* Skip pre-update checks on manual update

* Remove Composer Update step from Mautic updater

* Introduce composer_updates feature flag

* Fix CS

* Disable UI + CLI update if Composer update is enabled

* Cleanup

* Further cleanup

* Do not show the issue tracker button if there is no URL for issues

* Apply suggestions from code review

Co-authored-by: John Linhart <jan@linhart.email>

* Revert "Apply suggestions from code review"

This reverts commit a4c6a1b74ea419946ce64e7b905f1905b6bd60b3.

* Add lots of error handling to AjaxController

* Update URLs to docs in most places

* Additional error handling

* Remove double cache clear as it crashes the application

* Localization

* Fix tests

* Add more tests

* Fixing phpstan issues

* Add more tests

* Fixing bug discovered by the tests :tada:

* Add new plugin events (Acquia)

* Added new sortable columns to landing pages table, created at, modified date, createdby

* Set default order to decreasing modified date

* At creation of landing set also modified date

* Added index action test to PageControllerTest

* changed format date

* refactor(pagelist): use long date on tooltip

* fix(tableorder): at default order icon is asc and not desc, i change the default behavior

Changed default icon to asc and added another option "orderDir" for default icon, cant be used
option "dir" because it will be fixed the icon at one order. I also set orderbydir session at init
in PageController, because setListFilters method inside CommonController has ASC as default
behavior. If don't do it after first click on modified date icon the order will be again DESC, i
need that it will be converted to ASC.

* refactor(pageslist): changed init of dir param

* test(pagecontrollertest): added tests for page list, check if columns exist and order is correct

* refactor(pagecontroller): remove if condition and use default order to session

* Introduce options in fm_elfinder config

* Remove defaultDir parameter

* Fix default ordering for SMS

* Guess session base If not exists from deprecated parameter from old abstract class

* Fix default ordering for Assets

* Fix default ordering for Forms

* Add return type

* Fix ordering for Pages

* Keep same direction If switch column ordering

* Revert "Regenerate production assets"

This reverts commit 92f4db556cb3403141177a1238d085977ad8d7ee.

* Add missing argument to remove command

* Revert app.js

* Real revert app.js

* Fix event dispatching in ReloadHelper

* Revert "Introduce options in fm_elfinder config"

This reverts commit f4b64615810933fb7d89468cdff2614d4bb55eba.

* Revert "create test"

This reverts commit 67f97df7df3c8420afc9371a0a6eb49e49771787.

* Add unit test

* Improve boolean import/API support #7513

* Fix PHPStan

* Fix PHPStan

* Fix PHPStan and CS

* Added the ordered columns creation date and modified date

* Moved ID column to the end

* Added created by column

* Changed method for date

* Removed visible-md

* Added test for index action

* CreatedBy is visible only on lg

* Replace toFull with toFullConcat

* refactor(list.html.php): added escape and show full date only on hover

* test(emailcontrollerfunctionaltest): modified a test

now test if email contains saved fields

* feat(emailcontroller): changed default order to date modified

* refactor(emaillist): added default order to datemodified

* feat(email): set added date and modified date in Email construct

* feat(emaillist): changed default order to desc

* Remove non-working installation button from table

* Testing for more bool values

* Porting failing test from API Library

Mautic\Tests\Api\CampaignsTest::testCampaignContactEditEvent

* Fixing the  error "Call to a member function getTimestamp() on null"

* Improving error messages with concrete IDs

* Fixing param/return types for LeadEventLog entity

Because the original bug happened because they were not correct

* CS fixes

* Added space at the end of the file

* add extra checks in the misc job

* Fix scaffolded files that are out of sync

* reverted renamed tests, as it breaks the reporting

* Fix unit tests

* Fix email ordering

* Same date formatting also for campaigns

* Fix change order for default way

* Add unit tests for landing page

* Move getDefaultOrderDirection to CommonController

* Update app/bundles/CoreBundle/Controller/CommonController.php

Co-authored-by: John Linhart <jan@linhart.email>

* Add return type for getDefaultOrderDirection

* Revert back strict return type

* More unit tests

* Refactor unit tests to trait

* Add asset controller test

* Stop unnecessary query (#10876)

* Ensure unnecessary update queries won't happen

UPDATE leads SET last_active = ... WHERE id IS NULL

* Improving a test by replacing mocks with real objects

* Reusable getStandardColumns method (#10898)

* Move getStandardColumns method into the helper so it can be reused in other places.

* Fix the test.
Don't mock the ReportHelper. There is no need to mock it.

* Increase code coverage.

* Type fixes

* CS fix

* Fixing types

Co-authored-by: Anton Vlasenko <vlasenko.anton@gmail.com>

* Add UI update deprecation notice (#10907)

* Merge pull request from GHSA-mj6m-246h-9w56

* only allow access to specific PHP files in their specific location

* same change is needed in .htaccess file scaffolded in mautic/core-lib

* improved wording in comments

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* loosened regex to allow index_dev.php requests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Bump to 4.2.0 stable

* Revert - remove dependency on pre-installed mautic (local.php file) when running tests (#10909)

Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>

* add missing whitespace (#10923)

* restrict workflows with impact to mautic/mautic (#10894)

* restrict workflows with impact to mautic/mautic

* no codecov wanted either

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Dynamic content events (#10886)

* add events to segment filters dictionary generation, alter choices event to be more dynamic, make filter type public, alter choices form to allow translation keys without prefix as fallback. update reference to CO bundle

* code style fixes

* add events for DynC. for Cust.O.

* minor changes, maybe will be reverted

* split factory for sergments filter in two methods, so we can use it elsewhere

* cs fixes

* cs cleanup

* cs cleanup

* remove php 7 stuff

* Update app/bundles/LeadBundle/Event/SegmentDictionaryGenerationEvent.php

Co-Authored-By: galvani <galvani78@gmail.com>

* Update app/bundles/LeadBundle/Segment/ContactSegmentFilterCrate.php

* catch and ignore PDO exceptions in cache:clear process in CacheBundle, Move ContactFiltersEvent to DynamicContent bundle and fix references

* fix existing tests to mock new service arguments

* Update app/bundles/LeadBundle/Segment/ContactSegmentFilterFactory.php

Co-Authored-By: galvani <galvani78@gmail.com>

* Update app/bundles/DynamicContentBundle/Helper/DynamicContentHelper.php

Co-Authored-By: galvani <galvani78@gmail.com>

* fix cs errors

* Fixes after a wild cherry-pick of an antient missing commits

* One more round of after cherry-pick conflict cleanup

* Stan and CS fixes

* Covering the new method with tests

Co-authored-by: Jan Kozak <galvani78@gmail.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Allow composer scripts to use php-cs-fixer configuration (#10624)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Added provision to check is editted segment is new. (#10003)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Added support for MySQL full-text search queries (#9335)

* Added support for MySQL full-text search queries

* Composer conflicts resolved

* Conflict resolved

* Moving the new package to the right composer.json

* Fixing typehints

Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>

* fix segments list order (#10938)

* fix(segments): fixed session var name from segment to lead.list

* test(listcontrollertest): added a new test for list page

* Feature new click filters (#9852)

* Adds SMS and Email clicked date based segment filters

* Add support for clicking any link in any sms period

* Removed unused code

* Add manual SMS dnc filters

* Process SMS dnc manual unsubscribe filter

* Added missing dependency

* Fixed ChannelClickQueryBuilder for "did not click" filters

* Add new filter tests

* Type fixes

* Fixing PHP notice

PHP Notice - Uninitialized string offset: 0" at FieldFilterTransformer.php line 94

Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: Joey Keller <jos0405@gmail.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Remove doc blocks TPROD-131 (#10970)

* Adding new CS Fixer rule to remove doc blocks

* Removing docblocks

See https://mautic.atlassian.net/browse/TPROD-131

* Running the CS fixer again to remove the double new lines

* Runing CS Fixer for the 3rd time

* More CS fixes

* Fixing PHPSTAN issues in anonymous classes as those depend on line number which has changed after removing doc blocks

* Segment query optimizatioin  (#10904)

* Optimized DoNotContactFilterQueryBuilder

* Optimized addNewContactsRestrictions query

* DoNotContactFilterQueryBuilder test

* ContactSegmentQueryBuilder test

* Fixed failing tests when merged into development branch

* Removed call-time unnecessary parameters

* CS fixes

* Fixing test

The string must have an underscore in it

* Fixing DoNotContactParts for all options

Co-authored-by: fedys <miroslav.fedeles@gmail.com>

* Import validation (#10884)

* Validate imports to require mapping required fields

* Refactor required field validation for imports to event system

* Skip the CheckPassword validation group when associating a User entity as Owner

* Utilize the ArrayHelper class to reduce boilerplate.

* Ensure tags is an array

* Check all required company fields are mapped if any company fields are mapped during a contact import.

* Fixes after difficult conflict resolution

* Syntax sugar

* Adding functional tests for contct import

* Removing the deprecation notice as it does not make sense

The $flashBag property is private so no controller that inherits from this one can use it. Also, making it protected is a BC break as it breaks one of our plugin which use the same property already.

* Adding COMMAND_NAME const to avoid using strings in the tests

* Adding a validation error message if the file is not provided

* Adding logging to get some trace about why the import was reseted, light refactoring

* Access to an undefined property ImportController::$model

* Adding test with fixes discovered by it

* CS Fixes

* PHPSTAN fixes

* CS Fixes

* We cannot overwrite the getModel method as it's used from paretns with different model names

Co-authored-by: Don Gilbert <don.gilbert@mautic.com>

* docs: add Damzoneuh as a contributor for code (#10983)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Segment delegate decorator event (#10890)

* make sub-querybuilders pass paramater types along and allow to bypass decorator to get crate value

* cs fixes?

* tests for dynamic content

* update reference to CO plugin

* update reference co bundle, fix cs

* fix tests, cover event dispatch with test

* remove use statements from config

* replace int value with constant

* add argument removed on cleanup

* add helper method

* Fixes after wild cherry-pick conflict resolutions of antient commits

* New PHP syntax suggar

* CS fix

* Improving tests

* CS fix

* CS fix

* CS fix

Co-authored-by: Jan Kozak <galvani78@gmail.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fixing BC change after moving some segment filters to behaviors (#11003)

* Merge 4.2 branch back to 4.x (#11015)

* add missing whitespace (#10922)

* Fix segment membership filter build query (#10809)

* Fix segment membership filter build query

* Fix addLogic based on and/or

* Add unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix report date filter (#10800)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix email translations lost and overwritten by parent (#10620)

* Fix email translations lost and overwritten by parent

* Add unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix for Amazon API transport return-path when sending emails immediately (#10474)

* Fix for Amazon API transport return-path when sending immediately

* Added test for getBatchRecipientCount in AmazonApiTransport

* fix phpstan

* cs fix

* fix_cs

* fix the test

* Revert method signatures in AmazonApiTransport

* fix phpstan

* Add missing amazon message batch test

Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix timezone on timeline (#10375)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix API Permission Issue (#10679)

* Fix Api Permissions Issue

* Updated Api permission issue functional test

* Removed unused namespace

* Fix functional test case

* Fixed Functional Test

* Fix failed tests

Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix integration special fields order (#10649)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix set import template If use legacy builder (#10897)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* restrict workflows with impact to mautic/mautic (4.2) (#10924)

* restrict workflows with impact to mautic/mautic

* no codecov wanted either

* Validate admin password length during install

* Added test

* Fix primary email company tokens (#10733)

* Fix primary email company tokens

* Fix unit tests

* Add break If we find primary company value

Co-authored-by: mmarton <marton@webdream.hu>

Co-authored-by: mmarton <marton@webdream.hu>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Public preview email disabled by default (#10845)

* Public preview email disabled by default

* Add unit tests

* Add resposne content to failed unit tests

* Add flush

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Update to use default release notes, remove file (#10934)

* Display just published fields in form field mapping (#10734)

* Display just published fields in form field mapping

* Add unit tests

* Unit tests clean up

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* move changelog to the toplevel instead of a task (#10948)

* fix segments list order (#10968)

* fix(segments): fixed session var name from segment to lead.list

* test(listcontrollertest): added a new test for list page

* Migration fixes (#10931)

* Fixing skip migration check...

... as it should not check for the foreign keys but only if the table exists. The foreign keys must exist when the table exists either by running this migration or installing Mautic from entities

* Fixing migration check...

... as it was checking for wrong index name without the prefix and then the rename query was run on an index that do not exist.

* Actually, the checks were fine but used double table prefix

* CS fix

* Fix prevent save alias of contact field already used in segments (#10224)

* Fix prevent save alias of contact field already used in segments

* fix unit test

* CS fixer

* Fix PHPStan

* Remove SegmentFiltersSubscriber.php from configuration

* Resolve conflicts after segments refactoring

* Fix unit tests

Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix public preview email for expired emails (#10971)

* Fix public preview email for expired emails

* Add unit test

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Small grammar fix (#10977)

* Tags on edit should display same message as other entities, for e.g. xyz has been updated! (#10984)

* MAUT-7170: Tags on edit should display same message as other entities, for e.g. xyz has been updated!: M4

* MAUT-7170: Tags on edit should display same message as other entities, for e.g. xyz has been updated!: M4

* Remove clone option from tag manager

Co-authored-by: Saurabh Gupta <saurabh.gupta@acquia.com>

* Export to CSV and Excel creates contact duplicates (#10849)

* Fix duplicate contacts when exporting

* Fix code style

* Fix code style

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Missing include/exclude operator for text field in segment filters (#10985)

* WIP: Fix: No include/exclude operator for text field in segment filters.

* Use method available in the interface

Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>

* Fixes updating the contact's primary company when all companies are removed or one of many companies are removed (#11000)

* Fixes updating the contact's primary company when all companies are removed or one of many companies are removed

* Added some additional comments

* Cleaned up the tests a bit and added a check for the primary company in the details dropdown

* Prevent phpunit warning due to using a private method with a test prefix

* CS, STAN fixes

* Test fix

Co-authored-by: Alan Hartless <alan@devkardia.com>

* Special characters of the text getting corrupted while posting results to another form (#10872)

* Special characters of the text getting corrupted while posting results to another form

* Fixing PHPStan issue

* Fix for single code decoding

* Added file copyrights details

* fix CS faling check and adding type declation for variables

* fixing CS-Fixer

* fixing CS-Fixer

* Fix failed test

Co-authored-by: John Linhart <admin@escope.cz>

* Segment filter 'Asset Downloads' not showing all assets (#11002)

* MAUT-3795: Segment filter 'Asset Downloads' not showing all assets

* MAUT-3795: Keep existing filter data for asset downloads after ajax search

* MAUT-3795: Fixing submit issue for asset downloads filter

* STAN fixes

* There is no request service in AssetModel

Co-authored-by: Liju P M <liju.pm@acquia.com>

* Bump to 4.2.1

* Fix issue with changelog (#11012)

* Move release notes to separate file (#11014)

* Fixes needed after 4.2 to 4.x merge (CS, STAN, UNIT)

* CS fix

Co-authored-by: mollux <mattias.michaux@dropsolid.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Patryk Gruszka <patryk.gruszka@comarch.pl>
Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Rahul Dhande <68939488+rahuld-dev@users.noreply.github.com>
Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: mmarton <marton@webdream.hu>
Co-authored-by: Alfredo Arena <50916237+alfredoct96@users.noreply.github.com>
Co-authored-by: Damzoneuh <44919863+Damzoneuh@users.noreply.github.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Saurabh Gupta <saurabh.gupta@acquia.com>
Co-authored-by: Volha Pivavarchyk <volha@aivie.ch>
Co-authored-by: Alan Hartless <alan@devkardia.com>
Co-authored-by: Liju P M <liju.pm@acquia.com>

* CS fix

* CS fix

Co-authored-by: Alfredo Arena <alfredo.arena@ctmobi.it>
Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Anton Vlasenko <vlasenko.anton@gmail.com>
Co-authored-by: Joey Keller <jos0405@gmail.com>
Co-authored-by: Dennis Ameling <dennis@dennisameling.com>
Co-authored-by: Dennis Ameling (he/him) <dennis.ameling@leap.ac>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Mattias Michaux <mattias.michaux@dropsolid.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Jan Kozak <galvani78@gmail.com>
Co-authored-by: Miroslav Fedeleš <miroslav.fedeles@gmail.com>
Co-authored-by: Alfredo Arena <50916237+alfredoct96@users.noreply.github.com>
Co-authored-by: Alan Hartless (he/him) <alan@devkardia.com>
Co-authored-by: Don Gilbert <don.gilbert@mautic.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Patryk Gruszka <patryk.gruszka@comarch.pl>
Co-authored-by: Rahul Dhande <68939488+rahuld-dev@users.noreply.github.com>
Co-authored-by: mmarton <marton@webdream.hu>
Co-authored-by: Damzoneuh <44919863+Damzoneuh@users.noreply.github.com>
Co-authored-by: Saurabh Gupta <saurabh.gupta@acquia.com>
Co-authored-by: Volha Pivavarchyk <volha@aivie.ch>
Co-authored-by: Liju P M <liju.pm@acquia.com>

* Removing unused inteface and methods it required (#11056)

* 4.x to 5.x (#11115)

* Implement notification in the template.

* Add a config and a form for segment settings.

* Add a template for the config.

* Fix translations

* Fix translations

* Use an actual value from the config in the template.

* Update last_built_date value when we execute mautic:segments:update command.

* Update last_built_date value when we execute mautic:segments:update command.

* Fix code style.

* Update last_built_date when we create a segment.

* Fix a bug  with built_last_date when cloning LeadList entity.

* Fix method return type.

* Fix class name.

* Fix UpdateLeadListsCommand command.

* Add a segment config type test.

* Add a config subscriber test.

* Fix pluralization.

* Add tests for LeadList entity class.

* Refactor variables names (as was suggessted here https://github.com/mautic-inc/mautic-cloud/pull/942/files#r475729087).

* Rename LeadList::updateLastBuiltDate to LeadList::setLastBuiltDateToCurrentDatetime as suggested here: https://github.com/mautic-inc/mautic-cloud/pull/942/files#r475720725

* CS fixes

* Type fixes

* PHP 7.4 syntax sugar

* Fixing a bug caused by cherry-picking discovered by unit tests (:tada:)

* Adding test for the issue found during testing

The condition for max contacts param was opposit to what we want

* Forgot to add the test

* CS fix

* Asserting also the segment member count

* Set default values for original_is_published_value and column_is_not_created columns so older migrations won't fail

* Updating migrations to M4

* Fixing comparison value for the default value

* Fix accessibility of HTML Emails

* Add unit tests

* Remove unused class reported from PHPStan

* Fix Call to a member function getLanguage() on null

* Using the subject directly without the token, more test cases

* CS fixes

* Fix default order dir in controllers

* Set orderBy to session If does not exist

* Revert back CS fixer tableheader.html.php

* First work on Composer integration

* Add Composer dependency to Mautic

* Use KernelInterface to get project directory

* Explicitly set version of mautic/core-lib to v4

* Fix CS

* WIP Marketplace UI installation

* WIP UI installer now working

* Fix removal of plugins through UI + memory issues

* Fix CS

* Changes shown at live demo MautiCon

* Fix CS

* Fix PHPSTAN

* Parse + cache allowlist from GitHub

* Refactor allowlist into its own service

* Fix DI config

* Fix failing tests

* Fix AjaxController

* Add composer.json and composer.lock to full package, but not in update package

* Add some basic error handling to cache clear in AjaxController

* Catch errors, add dry-run functionality

* Add tests

* Forgot to push dummy allowlist

* Add additional tests

* Fix PHPSTAN

* Refactor Composer service into ComposerHelper in core, add Composer update step to Mautic update

* Remove ext-imap as hard Composer requirement

* Bump composer/composer to latest version for testing

* Bump composer/composer to 2.2 for speed/memory improvements

* Lock composer/composer version to prevent issues while updating Mautic

* Skip pre-update checks on manual update

* Remove Composer Update step from Mautic updater

* Introduce composer_updates feature flag

* Fix CS

* Disable UI + CLI update if Composer update is enabled

* Cleanup

* Further cleanup

* Do not show the issue tracker button if there is no URL for issues

* Apply suggestions from code review

Co-authored-by: John Linhart <jan@linhart.email>

* Revert "Apply suggestions from code review"

This reverts commit a4c6a1b74ea419946ce64e7b905f1905b6bd60b3.

* Add lots of error handling to AjaxController

* Update URLs to docs in most places

* Additional error handling

* Remove double cache clear as it crashes the application

* Localization

* Fix tests

* Add more tests

* Fixing phpstan issues

* Add more tests

* Fixing bug discovered by the tests :tada:

* Add new plugin events (Acquia)

* Added new sortable columns to landing pages table, created at, modified date, createdby

* Set default order to decreasing modified date

* At creation of landing set also modified date

* Added index action test to PageControllerTest

* changed format date

* refactor(pagelist): use long date on tooltip

* fix(tableorder): at default order icon is asc and not desc, i change the default behavior

Changed default icon to asc and added another option "orderDir" for default icon, cant be used
option "dir" because it will be fixed the icon at one order. I also set orderbydir session at init
in PageController, because setListFilters method inside CommonController has ASC as default
behavior. If don't do it after first click on modified date icon the order will be again DESC, i
need that it will be converted to ASC.

* refactor(pageslist): changed init of dir param

* test(pagecontrollertest): added tests for page list, check if columns exist and order is correct

* refactor(pagecontroller): remove if condition and use default order to session

* Introduce options in fm_elfinder config

* Remove defaultDir parameter

* Fix default ordering for SMS

* Guess session base If not exists from deprecated parameter from old abstract class

* Fix default ordering for Assets

* Fix default ordering for Forms

* Add return type

* Fix ordering for Pages

* Keep same direction If switch column ordering

* Revert "Regenerate production assets"

This reverts commit 92f4db556cb3403141177a1238d085977ad8d7ee.

* Add missing argument to remove command

* Revert app.js

* Real revert app.js

* Fix event dispatching in ReloadHelper

* Revert "Introduce options in fm_elfinder config"

This reverts commit f4b64615810933fb7d89468cdff2614d4bb55eba.

* Revert "create test"

This reverts commit 67f97df7df3c8420afc9371a0a6eb49e49771787.

* Add unit test

* Improve boolean import/API support #7513

* Fix PHPStan

* Fix PHPStan

* Fix PHPStan and CS

* Added the ordered columns creation date and modified date

* Moved ID column to the end

* Added created by column

* Changed method for date

* Removed visible-md

* Added test for index action

* CreatedBy is visible only on lg

* Replace toFull with toFullConcat

* refactor(list.html.php): added escape and show full date only on hover

* test(emailcontrollerfunctionaltest): modified a test

now test if email contains saved fields

* feat(emailcontroller): changed default order to date modified

* refactor(emaillist): added default order to datemodified

* feat(email): set added date and modified date in Email construct

* feat(emaillist): changed default order to desc

* Remove non-working installation button from table

* Testing for more bool values

* Porting failing test from API Library

Mautic\Tests\Api\CampaignsTest::testCampaignContactEditEvent

* Fixing the  error "Call to a member function getTimestamp() on null"

* Improving error messages with concrete IDs

* Fixing param/return types for LeadEventLog entity

Because the original bug happened because they were not correct

* CS fixes

* Added space at the end of the file

* add extra checks in the misc job

* Fix scaffolded files that are out of sync

* reverted renamed tests, as it breaks the reporting

* Fix unit tests

* Fix email ordering

* Same date formatting also for campaigns

* Fix change order for default way

* Add unit tests for landing page

* Move getDefaultOrderDirection to CommonController

* Update app/bundles/CoreBundle/Controller/CommonController.php

Co-authored-by: John Linhart <jan@linhart.email>

* Add return type for getDefaultOrderDirection

* Revert back strict return type

* More unit tests

* Refactor unit tests to trait

* Add asset controller test

* Stop unnecessary query (#10876)

* Ensure unnecessary update queries won't happen

UPDATE leads SET last_active = ... WHERE id IS NULL

* Improving a test by replacing mocks with real objects

* Reusable getStandardColumns method (#10898)

* Move getStandardColumns method into the helper so it can be reused in other places.

* Fix the test.
Don't mock the ReportHelper. There is no need to mock it.

* Increase code coverage.

* Type fixes

* CS fix

* Fixing types

Co-authored-by: Anton Vlasenko <vlasenko.anton@gmail.com>

* Add UI update deprecation notice (#10907)

* Merge pull request from GHSA-mj6m-246h-9w56

* only allow access to specific PHP files in their specific location

* same change is needed in .htaccess file scaffolded in mautic/core-lib

* improved wording in comments

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* loosened regex to allow index_dev.php requests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Bump to 4.2.0 stable

* Revert - remove dependency on pre-installed mautic (local.php file) when running tests (#10909)

Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>

* add missing whitespace (#10923)

* restrict workflows with impact to mautic/mautic (#10894)

* restrict workflows with impact to mautic/mautic

* no codecov wanted either

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Dynamic content events (#10886)

* add events to segment filters dictionary generation, alter choices event to be more dynamic, make filter type public, alter choices form to allow translation keys without prefix as fallback. update reference to CO bundle

* code style fixes

* add events for DynC. for Cust.O.

* minor changes, maybe will be reverted

* split factory for sergments filter in two methods, so we can use it elsewhere

* cs fixes

* cs cleanup

* cs cleanup

* remove php 7 stuff

* Update app/bundles/LeadBundle/Event/SegmentDictionaryGenerationEvent.php

Co-Authored-By: galvani <galvani78@gmail.com>

* Update app/bundles/LeadBundle/Segment/ContactSegmentFilterCrate.php

* catch and ignore PDO exceptions in cache:clear process in CacheBundle, Move ContactFiltersEvent to DynamicContent bundle and fix references

* fix existing tests to mock new service arguments

* Update app/bundles/LeadBundle/Segment/ContactSegmentFilterFactory.php

Co-Authored-By: galvani <galvani78@gmail.com>

* Update app/bundles/DynamicContentBundle/Helper/DynamicContentHelper.php

Co-Authored-By: galvani <galvani78@gmail.com>

* fix cs errors

* Fixes after a wild cherry-pick of an antient missing commits

* One more round of after cherry-pick conflict cleanup

* Stan and CS fixes

* Covering the new method with tests

Co-authored-by: Jan Kozak <galvani78@gmail.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Allow composer scripts to use php-cs-fixer configuration (#10624)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Added provision to check is editted segment is new. (#10003)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Added support for MySQL full-text search queries (#9335)

* Added support for MySQL full-text search queries

* Composer conflicts resolved

* Conflict resolved

* Moving the new package to the right composer.json

* Fixing typehints

Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>

* fix segments list order (#10938)

* fix(segments): fixed session var name from segment to lead.list

* test(listcontrollertest): added a new test for list page

* Feature new click filters (#9852)

* Adds SMS and Email clicked date based segment filters

* Add support for clicking any link in any sms period

* Removed unused code

* Add manual SMS dnc filters

* Process SMS dnc manual unsubscribe filter

* Added missing dependency

* Fixed ChannelClickQueryBuilder for "did not click" filters

* Add new filter tests

* Type fixes

* Fixing PHP notice

PHP Notice - Uninitialized string offset: 0" at FieldFilterTransformer.php line 94

Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: Joey Keller <jos0405@gmail.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Remove doc blocks TPROD-131 (#10970)

* Adding new CS Fixer rule to remove doc blocks

* Removing docblocks

See https://mautic.atlassian.net/browse/TPROD-131

* Running the CS fixer again to remove the double new lines

* Runing CS Fixer for the 3rd time

* More CS fixes

* Fixing PHPSTAN issues in anonymous classes as those depend on line number which has changed after removing doc blocks

* Segment query optimizatioin  (#10904)

* Optimized DoNotContactFilterQueryBuilder

* Optimized addNewContactsRestrictions query

* DoNotContactFilterQueryBuilder test

* ContactSegmentQueryBuilder test

* Fixed failing tests when merged into development branch

* Removed call-time unnecessary parameters

* CS fixes

* Fixing test

The string must have an underscore in it

* Fixing DoNotContactParts for all options

Co-authored-by: fedys <miroslav.fedeles@gmail.com>

* Import validation (#10884)

* Validate imports to require mapping required fields

* Refactor required field validation for imports to event system

* Skip the CheckPassword validation group when associating a User entity as Owner

* Utilize the ArrayHelper class to reduce boilerplate.

* Ensure tags is an array

* Check all required company fields are mapped if any company fields are mapped during a contact import.

* Fixes after difficult conflict resolution

* Syntax sugar

* Adding functional tests for contct import

* Removing the deprecation notice as it does not make sense

The $flashBag property is private so no controller that inherits from this one can use it. Also, making it protected is a BC break as it breaks one of our plugin which use the same property already.

* Adding COMMAND_NAME const to avoid using strings in the tests

* Adding a validation error message if the file is not provided

* Adding logging to get some trace about why the import was reseted, light refactoring

* Access to an undefined property ImportController::$model

* Adding test with fixes discovered by it

* CS Fixes

* PHPSTAN fixes

* CS Fixes

* We cannot overwrite the getModel method as it's used from paretns with different model names

Co-authored-by: Don Gilbert <don.gilbert@mautic.com>

* docs: add Damzoneuh as a contributor for code (#10983)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* Segment delegate decorator event (#10890)

* make sub-querybuilders pass paramater types along and allow to bypass decorator to get crate value

* cs fixes?

* tests for dynamic content

* update reference to CO plugin

* update reference co bundle, fix cs

* fix tests, cover event dispatch with test

* remove use statements from config

* replace int value with constant

* add argument removed on cleanup

* add helper method

* Fixes after wild cherry-pick conflict resolutions of antient commits

* New PHP syntax suggar

* CS fix

* Improving tests

* CS fix

* CS fix

* CS fix

Co-authored-by: Jan Kozak <galvani78@gmail.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fixing BC change after moving some segment filters to behaviors (#11003)

* Merge 4.2 branch back to 4.x (#11015)

* add missing whitespace (#10922)

* Fix segment membership filter build query (#10809)

* Fix segment membership filter build query

* Fix addLogic based on and/or

* Add unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix report date filter (#10800)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix email translations lost and overwritten by parent (#10620)

* Fix email translations lost and overwritten by parent

* Add unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix for Amazon API transport return-path when sending emails immediately (#10474)

* Fix for Amazon API transport return-path when sending immediately

* Added test for getBatchRecipientCount in AmazonApiTransport

* fix phpstan

* cs fix

* fix_cs

* fix the test

* Revert method signatures in AmazonApiTransport

* fix phpstan

* Add missing amazon message batch test

Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix timezone on timeline (#10375)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix API Permission Issue (#10679)

* Fix Api Permissions Issue

* Updated Api permission issue functional test

* Removed unused namespace

* Fix functional test case

* Fixed Functional Test

* Fix failed tests

Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix integration special fields order (#10649)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix set import template If use legacy builder (#10897)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* restrict workflows with impact to mautic/mautic (4.2) (#10924)

* restrict workflows with impact to mautic/mautic

* no codecov wanted either

* Validate admin password length during install

* Added test

* Fix primary email company tokens (#10733)

* Fix primary email company tokens

* Fix unit tests

* Add break If we find primary company value

Co-authored-by: mmarton <marton@webdream.hu>

Co-authored-by: mmarton <marton@webdream.hu>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Public preview email disabled by default (#10845)

* Public preview email disabled by default

* Add unit tests

* Add resposne content to failed unit tests

* Add flush

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Update to use default release notes, remove file (#10934)

* Display just published fields in form field mapping (#10734)

* Display just published fields in form field mapping

* Add unit tests

* Unit tests clean up

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* move changelog to the toplevel instead of a task (#10948)

* fix segments list order (#10968)

* fix(segments): fixed session var name from segment to lead.list

* test(listcontrollertest): added a new test for list page

* Migration fixes (#10931)

* Fixing skip migration check...

... as it should not check for the foreign keys but only if the table exists. The foreign keys must exist when the table exists either by running this migration or installing Mautic from entities

* Fixing migration check...

... as it was checking for wrong index name without the prefix and then the rename query was run on an index that do not exist.

* Actually, the checks were fine but used double table prefix

* CS fix

* Fix prevent save alias of contact field already used in segments (#10224)

* Fix prevent save alias of contact field already used in segments

* fix unit test

* CS fixer

* Fix PHPStan

* Remove SegmentFiltersSubscriber.php from configuration

* Resolve conflicts after segments refactoring

* Fix unit tests

Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix public preview email for expired emails (#10971)

* Fix public preview email for expired emails

* Add unit test

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Small grammar fix (#10977)

* Tags on edit should display same message as other entities, for e.g. xyz has been updated! (#10984)

* MAUT-7170: Tags on edit should display same message as other entities, for e.g. xyz has been updated!: M4

* MAUT-7170: Tags on edit should display same message as other entities, for e.g. xyz has been updated!: M4

* Remove clone option from tag manager

Co-authored-by: Saurabh Gupta <saurabh.gupta@acquia.com>

* Export to CSV and Excel creates contact duplicates (#10849)

* Fix duplicate contacts when exporting

* Fix code style

* Fix code style

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Missing include/exclude operator for text field in segment filters (#10985)

* WIP: Fix: No include/exclude operator for text field in segment filters.

* Use method available in the interface

Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>

* Fixes updating the contact's primary company when all companies are removed or one of many companies are removed (#11000)

* Fixes updating the contact's primary company when all companies are removed or one of many companies are removed

* Added some additional comments

* Cleaned up the tests a bit and added a check for the primary company in the details dropdown

* Prevent phpunit warning due to using a private method with a test prefix

* CS, STAN fixes

* Test fix

Co-authored-by: Alan Hartless <alan@devkardia.com>

* Special characters of the text getting corrupted while posting results to another form (#10872)

* Special characters of the text getting corrupted while posting results to another form

* Fixing PHPStan issue

* Fix for single code decoding

* Added file copyrights details

* fix CS faling check and adding type declation for variables

* fixing CS-Fixer

* fixing CS-Fixer

* Fix failed test

Co-authored-by: John Linhart <admin@escope.cz>

* Segment filter 'Asset Downloads' not showing all assets (#11002)

* MAUT-3795: Segment filter 'Asset Downloads' not showing all assets

* MAUT-3795: Keep existing filter data for asset downloads after ajax search

* MAUT-3795: Fixing submit issue for asset downloads filter

* STAN fixes

* There is no request service in AssetModel

Co-authored-by: Liju P M <liju.pm@acquia.com>

* Bump to 4.2.1

* Fix issue with changelog (#11012)

* Move release notes to separate file (#11014)

* Fixes needed after 4.2 to 4.x merge (CS, STAN, UNIT)

* CS fix

Co-authored-by: mollux <mattias.michaux@dropsolid.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Patryk Gruszka <patryk.gruszka@comarch.pl>
Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Rahul Dhande <68939488+rahuld-dev@users.noreply.github.com>
Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: mmarton <marton@webdream.hu>
Co-authored-by: Alfredo Arena <50916237+alfredoct96@users.noreply.github.com>
Co-authored-by: Damzoneuh <44919863+Damzoneuh@users.noreply.github.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Saurabh Gupta <saurabh.gupta@acquia.com>
Co-authored-by: Volha Pivavarchyk <volha@aivie.ch>
Co-authored-by: Alan Hartless <alan@devkardia.com>
Co-authored-by: Liju P M <liju.pm@acquia.com>

* Only upload release asset if not prerelease (#10882)

* Replace Client with KernelBrowser (#11049)

* TPROD-280 - The scale option was removed from the IntegerType (#11034)

* The scale option was removed from the IntegerType

* CSS style tweak

* Improve docs on builder events (#11047)

* Improve docs on builder events

* Fix PHPSTAN

* Fix PHPSTAN errors

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Add company_id search command (#10702)

* Add company_id search command

* Add unit tests

* Improve unit tests

* Add functional test

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* limit scheduled workflows to specific public repo's (#11062)

* Updating the email validation mode to work in Symfony 5.0 (#11054)

The strict mode requires another dependency to be added via Composer so I suggest to change it to the next best thing which is the same email validation as the HTML5 browsers do

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Removing options for TimeType that would cause an exception in Symfony 5.0 (#11040)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* rework the seek / fgets combo to be compatible with both PHP 7 and 8 (#11060)

* rework the seek / fget combo to be compatible with both PHP 7 and 8

* CS fixes

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Update LeadImportType.php (#11011)

Fixed Import validation when uploading a CSV file in Mautic 4.x with PHP 8

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* docs: add alinmbb as a contributor for code (#11065)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* split up of lead column structure and field data fixtures (#11059)

CS fixes and improvements

phpstan fixes

Update app/bundles/InstallBundle/Config/config.php

Co-authored-by: John Linhart <jan@linhart.email>

Co-authored-by: John Linhart <jan@linhart.email>

* Segment optimization IN to EXISTS (#10903)

* MAUT-3830 - WIP - change alias for inner query

* MAUT-3830 - WIP - introduce a way to get/set dynamic alias

* MAUT-3830 - WIP - MauticCitrixBundle changes

* MAUT-3830 - WIP - Builder changes

* MAUT-3830 - WIP - LeadListFilteringEvent.php cs-fixes

* MAUT-3830 - WIP

* MAUT-3830 - WIP - fix table alias false error

* MAUT-3830 - fix test case and lead limiter alias

* fix rebase issues, fixcs issues and add alias to foreign value filter

* Removing return types which are BC changes, Stan and CS fixes

* getTableAlias method must return string

* Fixing failing function segment tests by copy-pasting code changes missing in some segment query builders from our fork

* Fix of an issue caused by a rebase

Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>

* Dont show empty fields in the contact and company detail view (#11016)

* Don't show empty fields

* Fix test

* Fix test

* Show fields with a set value

* Improve code

Co-authored-by: John Linhart <jan@linhart.email>

Co-authored-by: John Linhart <jan@linhart.email>
Co-authored-by: John Linhart <admin@escope.cz>

* Updating image used for getting changed files (#11074)

Fixing error for GH Actions:

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

@see https://github.com/actions/checkout/issues/760

* Remove transChoice() as it is deprecated in Symfony 4.2 (#11046)

* Remove transChoice() as it is deprecated in Symfony 4.2 and will be removed in 5.0

* Replace trans() pluralization with '%count%' key and update ini files

* Update ini file

Co-authored-by: John Linhart <jan@linhart.email>

* Update ini file

Co-authored-by: John Linhart <jan@linhart.email>

Co-authored-by: John Linhart <jan@linhart.email>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: John Linhart <admin@escope.cz>

* Fix network issues when running composer in ddev (#11084)

* Deprecate AbstractIntegration (#11050)

Co-authored-by: John Linhart <admin@escope.cz>

* TPROD-281 - Test kernel boot fix for Symfony 5 (#11045)

* Test rewritten using enableReboot() method

* Method createAnotherClient() removed as it will not work in Symfony 5

* Unused import removed

Co-authored-by: John Linhart <admin@escope.cz>

* 4.2 to 4.x (#11112)

* add missing whitespace (#10922)

* Fix segment membership filter build query (#10809)

* Fix segment membership filter build query

* Fix addLogic based on and/or

* Add unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix report date filter (#10800)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix email translations lost and overwritten by parent (#10620)

* Fix email translations lost and overwritten by parent

* Add unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix for Amazon API transport return-path when sending emails immediately (#10474)

* Fix for Amazon API transport return-path when sending immediately

* Added test for getBatchRecipientCount in AmazonApiTransport

* fix phpstan

* cs fix

* fix_cs

* fix the test

* Revert method signatures in AmazonApiTransport

* fix phpstan

* Add missing amazon message batch test

Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix timezone on timeline (#10375)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix API Permission Issue (#10679)

* Fix Api Permissions Issue

* Updated Api permission issue functional test

* Removed unused namespace

* Fix functional test case

* Fixed Functional Test

* Fix failed tests

Co-authored-by: John Linhart <admin@escope.cz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix integration special fields order (#10649)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix set import template If use legacy builder (#10897)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* restrict workflows with impact to mautic/mautic (4.2) (#10924)

* restrict workflows with impact to mautic/mautic

* no codecov wanted either

* Validate admin password length during install

* Added test

* Fix primary email company tokens (#10733)

* Fix primary email company tokens

* Fix unit tests

* Add break If we find primary company value

Co-authored-by: mmarton <marton@webdream.hu>

Co-authored-by: mmarton <marton@webdream.hu>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Public preview email disabled by default (#10845)

* Public preview email disabled by default

* Add unit tests

* Add resposne content to failed unit tests

* Add flush

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Update to use default release notes, remove file (#10934)

* Display just published fields in form field mapping (#10734)

* Display just published fields in form field mapping

* Add unit tests

* Unit tests clean up

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* move changelog to the toplevel instead of a task (#10948)

* fix segments list order (#10968)

* fix(segments): fixed session var name from segment to lead.list

* test(listcontrollertest): added a new test for list page

* Migration fixes (#10931)

* Fixing skip migration check...

... as it should not check for the foreign keys but only if the table exists. The foreign keys must exist when the table exists either by running this migration or installing Mautic from entities

* Fixing migration check...

... as it was checking for wrong index name without the prefix and then the rename query was run on an index that do not exist.

* Actually, the checks were fine but used double table prefix

* CS fix

* Fix prevent save alias of contact field already used in segments (#10224)

* Fix prevent save alias of contact field already used in segments

* fix unit test

* CS fixer

* Fix PHPStan

* Remove SegmentFiltersSubscriber.php from configuration

* Resolve conflicts after segments refactoring

* Fix unit tests

Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix public preview email for expired emails (#10971)

* Fix public preview email for expired emails

* Add unit test

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Small grammar fix (#10977)

* Tags on edit should display same message as other entities, for e.g. xyz has been updated! (#10984)

* MAUT-7170: Tags on edit should display same message as other entities, for e.g. xyz has been updated!: M4

* MAUT-7170: Tags on edit should display same message as other entities, for e.g. xyz has been updated!: M4

* Remove clone option from tag manager

Co-authored-by: Saurabh Gupta <saurabh.gupta@acquia.com>

* Export to CSV and Excel creates contact duplicates (#10849)

* Fix duplicate contacts when exporting

* Fix code style

* Fix code style

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Missing include/exclude operator for text field in segment filters (#10985)

* WIP: Fix: No include/exclude operator for text field in segment filters.

* Use method available in the interface

Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>

* Fixes updating the contact's primary company when all companies are removed or one of many companies are removed (#11000)

* Fixes updating the contact's primary company when all companies are removed or one of many companies are removed

* Added some additional comments

* Cleaned up the tests a bit and added a check for the primary company in the details dropdown

* Prevent phpunit warning due to using a private method with a test prefix

* CS, STAN fixes

* Test fix

Co-authored-by: Alan Hartless <alan@devkardia.com>

* Special characters of the text getting corrupted while posting results to another form (#10872)

* Special characters of the text getting corrupted while posting results to another form

* Fixing PHPStan issue

* Fix for single code decoding

* Added file copyrights details

* fix CS faling check and adding type declation for variables

* fixing CS-Fixer

* fixing CS-Fixer

* Fix failed test

Co-authored-by: John Linhart <admin@escope.cz>

* Segment filter 'Asset Downloads' not showing all assets (#11002)

* MAUT-3795: Segment filter 'Asset Downloads' not showing all assets

* MAUT-3795: Keep existing filter data for asset downloads after ajax search

* MAUT-3795: Fixing submit issue for asset downloads filter

* STAN fixes

* There is no request service in AssetModel

Co-authored-by: Liju P M <liju.pm@acquia.com>

* Bump to 4.2.1

* Fix issue with changelog (#11012)

* Move release notes to separate file (#11014)

* Fix flip array for groups in select in segments filter (#9339)

* Fix flip array for sub array in segments filter

* Fix PHPStan

* Update app/bundles/CoreBundle/Helper/ArrayHelper.php

Co-authored-by: John Linhart <jan@linhart.email>

Co-authored-by: Dennis Ameling <dennis@dennisameling.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: John Linhart <jan@linhart.email>

* Add tag creation behavior for leads (#10969)

* Updating image used for getting changed files (#11075)

Fixing error for GH Actions:

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

@see https://github.com/actions/checkout/issues/760

* Fix network issues when running composer in ddev (#11089)

* use a more strict contraint for doctrine-bundle due to (BC?) breaking changes (#11053)

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Fix headers (including list-unsubscribe header) when using sendgrid-api (#10831)

* Fix headers (including list-unsubscribe header) when using sendgrid-api

* Apply CSFixer for concat_space, single_quote

Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>

* Remove multiselect field default value template (#11069)

* Remove multiselect field default value template

* Fix PHPStan

Co-authored-by: John Linhart <admin@escope.cz>

* Fix elFinder localization (#10987)

* Bump async from 3.2.0 to 3.2.3 in /plugins/GrapesJsBuilderBundle (#11076)

Bumps [async](https://github.com/caolan/async) from 3.2.0 to 3.2.3.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v3.2.0...v3.2.3)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* change link from edit to view once company modification saved (#11098)

Co-authored-by: John Linhart <admin@escope.cz>

* Update CONTRIBUTING.md (#11100)

* Fix and redesign sms characters count (#10838)

* Fix and redesign sms characters count

* Reformat HTML

Co-authored-by: John Linhart <admin@escope.cz>

* Custom html is hidden when GrapesJS is disabled (#11102)

* Fixing custom field with an empty option (#11101)

* Fix dependency issue (#11085)

* Fix dependency issue within functional tests

* Added fixtures test case.

Co-authored-by: fedys <miroslav.fedeles@gmail.com>

* 4.2.2 bump (#11109)

* Bumping to version 4.2.2

* Production assets generated

Needed for Mautic instances installed via Composer

* Fixing PHPSTAN after bad merge

* CS fix

* Removing unused var

Co-authored-by: mollux <mattias.michaux@dropsolid.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Patryk Gruszka <patryk.gruszka@comarch.pl>
Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Rahul Dhande <68939488+rahuld-dev@users.noreply.github.com>
Co-authored-by: mmarton <marton@webdream.hu>
Co-authored-by: Alfredo Arena <50916237+alfredoct96@users.noreply.github.com>
Co-authored-by: Damzoneuh <44919863+Damzoneuh@users.noreply.github.com>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Saurabh Gupta <saurabh.gupta@acquia.com>
Co-authored-by: Volha Pivavarchyk <volha@aivie.ch>
Co-authored-by: Alan Hartless <alan@devkardia.com>
Co-authored-by: Liju P M <liju.pm@acquia.com>
Co-authored-by: Dennis Ameling <dennis@dennisameling.com>
Co-authored-by: julienWebmecanik <79137416+julienWebmecanik@users.noreply.github.com>
Co-authored-by: Ofer Shaal <shaalofer@gmail.com>
Co-authored-by: Renato Santos <renato.cron@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Norman Pracht - Webmecanik <npr@webmecanik.com>
Co-authored-by: fedys <miroslav.fedeles@gmail.com>

* STAN fix

* Code missing from the merge added

Co-authored-by: Anton Vlasenko <vlasenko.anton@gmail.com>
Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
Co-authored-by: Joey Keller <jos0405@gmail.com>
Co-authored-by: Dennis Ameling <dennis@dennisameling.com>
Co-authored-by: Dennis Ameling (he/him) <dennis.ameling@leap.ac>
Co-authored-by: Tejas Navghane <ts.navghane@gmail.com>
Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Alfredo Arena <alfredo.arena@ctmobi.it>
Co-authored-by: Mattias Michaux <mattias.michaux@dropsolid.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Jan Kozak <galvani78@gmai…
vhotspur added a commit to renaissance-benchmarks/renaissance that referenced this issue Mar 28, 2023
adamdmoss pushed a commit to adamnv/vkd3d-proton that referenced this issue Apr 27, 2023
See actions/checkout#760 for reference.

Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
LucaGuerra pushed a commit to LucaGuerra/libs that referenced this issue May 16, 2023
@melroy89
Copy link

It's actually for some reason still not solved. Despite the git config command within the checkout action, for some reason I still get this issue.

@krystian3w
Copy link

krystian3w commented Jun 28, 2023

CSS clean up "tool" for web version:

div[data-url^="/actions/checkout/issues/760/"] ~ div
    .TimelineItem ~ div
        [data-gid]:not([data-gid^="IC"]) {
            display: none !important;
}

Hides 11 elements (with 48 random references) {and 76 elements on full loaded topic [662 references]}.

@sambacha
Copy link

If you want to bypass the issue:

cat <<EOF >> /etc/gitconfig
[safe]
        directory = *
EOF

upalmer pushed a commit to flir-cx/meta-flir-base that referenced this issue Aug 14, 2023
~2022-04-13, "bitbake flir-image" suddenly stopped working
Tracked down to an ubuntu package update of git (git version 2.25.1),
~ the day before
As bitbake builds in a "pseudo" environment, it runs as user 0
and then (with latest git) now complaints about .repo/manifests repo
owned by by "somebody else" (i.e. $USER - actually us as not pseudo)

The problem is described in:
actions/checkout#760
The proposed workaround is ugly; it involves patching
"your" ~/.gitconfig
For now I do not find any better solution.

Hopefully the maintainers of git and/or ubuntu finds a better (?) way
to handle the supposed security flaw they claim that they fixed
(which has the described side effects)
Time will tell...
Until then, this fix will do.
mauwii added a commit to mauwii/act-docker-images that referenced this issue Sep 16, 2023
- Git version 2.35.2 introduces security fix that breaks action\checkout
- actions/checkout#760
mauwii added a commit to mauwii/act-docker-images that referenced this issue Sep 16, 2023
* fix git checkout action
- Git version 2.35.2 introduces security fix that breaks action\checkout
- actions/checkout#760

* update README

* execute Docker Scout only on PRs

* add examples for secrets and vars file

* add elif to cspell

* add .secrets and .vars to .gitignore
linogaliana added a commit to linogaliana/test-light-python-datascientist that referenced this issue Oct 12, 2023
* premeir test quarto

* validate yaml

* Continue avec quarto

* modification badge vscode

* passage sous forme de projet quarto

* commence à tatonner sur action

* hugo build

* update

* Ajoute des arguments au build

* ajoute l'option par défaut wrap

* modif

* Ajoute une exception pour build

* Workaround actions/checkout#760

* restructure page bundle

* rename

* retire bout problématique

* Force rendering _index.qmd

* mathjax

* gère chemin images

* ajoute image reshape

* ajoute image join

* Delete pandas_join.png

* mv file

* Ajoute le TP pandas

* quarto

* adapte le notebook

* retire fix

* file

* correction

* ajoute image

* déplace deux TP

* rename file

* rename

* typo folium

* corrige typo dans chapitre geopandas

* retour titre

* output asis

* corrige erreur

* corrige erreur

* dep

* dep

* surface

* corrige des typos

* carte arrondissements

* figures by pandas

* finalise cleaning gpd

* arrange

* Ajoute des ancres

* essaie à nouveau la construction des notebooks

* essaie à nouveau la construction des notebooks

* change artifacts dir

* change section name

* ajoute corrections au worfjlow

* ajoute corrections au worfjlow

* Qmd maps

* corrige clé

* convert matplotlib tuto

* clean qmd

* echo false

* feature engineering

* ajoute index

* Modélisation chapitre 2

* update

* tp regression

* ajoute feature selection

* clustering

* création fichier pipeline

* finit le fichier

* prb exec

* corrige erreurs

* import pandas

* no more r

* update

* ajoute image

* ajoute index

* ajoute image scikit

* typo

* duplication image

* duplication image

* les deux premiers chapittes NLP

* ajoute download

* python LDA

* error

* Exos supp

* chapitre elastic

* chapitre elastic

* rename utils

* rename

* refactorise

* introgit

* change anem

* refactorise

* refactorise

* S3

* shell

* typo

* liste TP supprimée

* update

* update wordcloud

* retour du wordcloud

* erreur nom badge

* update

* raw shortcode

* ajoute hack shortcode

* update

* en eval false

* retire import brut image

* tente un seul job pour les notebooks

* nettoie tous les shortcodes

* retire dossier notebooks

* force

* Automated changes

* script to hack names

* hack names

* add move files

* dir create

* Automated changes

* corrige typo

* Automated changes

* Automated changes

* force commit

* Automated changes

* Automated changes

* test ligne à ligne

* Automated changes

* Automated changes

* trying differently

* Automated changes

* change git add

* Automated changes

* Automated changes

* widlcard aussi là

* updae

* Automated changes

* Automated changes

* qmdise

* tuto word2vec

* les derniers TP

* retire R

* eval false pour tester

* retour

* eval false

* eval false

* retire

* Automated changes

* simplifie elastic

* master

* Automated changes

* Automated changes

* rewrite

* Automated changes

* Automated changes

* clean

* Automated changes

* resub

* Automated changes

* Automated changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
linogaliana added a commit to linogaliana/python-datascientist that referenced this issue Oct 13, 2023
* premeir test quarto

* validate yaml

* Continue avec quarto

* modification badge vscode

* passage sous forme de projet quarto

* commence à tatonner sur action

* hugo build

* update

* Ajoute des arguments au build

* ajoute l'option par défaut wrap

* modif

* Ajoute une exception pour build

* Workaround actions/checkout#760

* restructure page bundle

* rename

* retire bout problématique

* Force rendering _index.qmd

* mathjax

* gère chemin images

* ajoute image reshape

* ajoute image join

* Delete pandas_join.png

* mv file

* Ajoute le TP pandas

* quarto

* adapte le notebook

* retire fix

* file

* correction

* ajoute image

* déplace deux TP

* rename file

* rename

* typo folium

* corrige typo dans chapitre geopandas

* retour titre

* output asis

* corrige erreur

* corrige erreur

* dep

* dep

* surface

* corrige des typos

* carte arrondissements

* figures by pandas

* finalise cleaning gpd

* arrange

* Ajoute des ancres

* essaie à nouveau la construction des notebooks

* essaie à nouveau la construction des notebooks

* change artifacts dir

* change section name

* ajoute corrections au worfjlow

* ajoute corrections au worfjlow

* Qmd maps

* corrige clé

* convert matplotlib tuto

* clean qmd

* echo false

* feature engineering

* ajoute index

* Modélisation chapitre 2

* update

* tp regression

* ajoute feature selection

* clustering

* création fichier pipeline

* finit le fichier

* prb exec

* corrige erreurs

* import pandas

* no more r

* update

* ajoute image

* ajoute index

* ajoute image scikit

* typo

* duplication image

* duplication image

* les deux premiers chapittes NLP

* ajoute download

* python LDA

* error

* Exos supp

* chapitre elastic

* chapitre elastic

* rename utils

* rename

* refactorise

* introgit

* change anem

* refactorise

* refactorise

* S3

* shell

* typo

* liste TP supprimée

* update

* update wordcloud

* retour du wordcloud

* erreur nom badge

* update

* raw shortcode

* ajoute hack shortcode

* update

* en eval false

* retire import brut image

* tente un seul job pour les notebooks

* nettoie tous les shortcodes

* retire dossier notebooks

* force

* Automated changes

* script to hack names

* hack names

* add move files

* dir create

* Automated changes

* corrige typo

* Automated changes

* Automated changes

* force commit

* Automated changes

* Automated changes

* test ligne à ligne

* Automated changes

* Automated changes

* trying differently

* Automated changes

* change git add

* Automated changes

* Automated changes

* widlcard aussi là

* updae

* Automated changes

* Automated changes

* qmdise

* tuto word2vec

* les derniers TP

* retire R

* eval false pour tester

* retour

* eval false

* eval false

* retire

* Automated changes

* simplifie elastic

* master

* Automated changes

* Automated changes

* rewrite

* Automated changes

* Automated changes

* clean

* Automated changes

* resub

* Automated changes

* Automated changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
linogaliana added a commit to linogaliana/python-datascientist-trim2 that referenced this issue Dec 2, 2023
* premeir test quarto

* validate yaml

* Continue avec quarto

* modification badge vscode

* passage sous forme de projet quarto

* commence à tatonner sur action

* hugo build

* update

* Ajoute des arguments au build

* ajoute l'option par défaut wrap

* modif

* Ajoute une exception pour build

* Workaround actions/checkout#760

* restructure page bundle

* rename

* retire bout problématique

* Force rendering _index.qmd

* mathjax

* gère chemin images

* ajoute image reshape

* ajoute image join

* Delete pandas_join.png

* mv file

* Ajoute le TP pandas

* quarto

* adapte le notebook

* retire fix

* file

* correction

* ajoute image

* déplace deux TP

* rename file

* rename

* typo folium

* corrige typo dans chapitre geopandas

* retour titre

* output asis

* corrige erreur

* corrige erreur

* dep

* dep

* surface

* corrige des typos

* carte arrondissements

* figures by pandas

* finalise cleaning gpd

* arrange

* Ajoute des ancres

* essaie à nouveau la construction des notebooks

* essaie à nouveau la construction des notebooks

* change artifacts dir

* change section name

* ajoute corrections au worfjlow

* ajoute corrections au worfjlow

* Qmd maps

* corrige clé

* convert matplotlib tuto

* clean qmd

* echo false

* feature engineering

* ajoute index

* Modélisation chapitre 2

* update

* tp regression

* ajoute feature selection

* clustering

* création fichier pipeline

* finit le fichier

* prb exec

* corrige erreurs

* import pandas

* no more r

* update

* ajoute image

* ajoute index

* ajoute image scikit

* typo

* duplication image

* duplication image

* les deux premiers chapittes NLP

* ajoute download

* python LDA

* error

* Exos supp

* chapitre elastic

* chapitre elastic

* rename utils

* rename

* refactorise

* introgit

* change anem

* refactorise

* refactorise

* S3

* shell

* typo

* liste TP supprimée

* update

* update wordcloud

* retour du wordcloud

* erreur nom badge

* update

* raw shortcode

* ajoute hack shortcode

* update

* en eval false

* retire import brut image

* tente un seul job pour les notebooks

* nettoie tous les shortcodes

* retire dossier notebooks

* force

* Automated changes

* script to hack names

* hack names

* add move files

* dir create

* Automated changes

* corrige typo

* Automated changes

* Automated changes

* force commit

* Automated changes

* Automated changes

* test ligne à ligne

* Automated changes

* Automated changes

* trying differently

* Automated changes

* change git add

* Automated changes

* Automated changes

* widlcard aussi là

* updae

* Automated changes

* Automated changes

* qmdise

* tuto word2vec

* les derniers TP

* retire R

* eval false pour tester

* retour

* eval false

* eval false

* retire

* Automated changes

* simplifie elastic

* master

* Automated changes

* Automated changes

* rewrite

* Automated changes

* Automated changes

* clean

* Automated changes

* resub

* Automated changes

* Automated changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
linogaliana added a commit to linogaliana/python-datascientist that referenced this issue Dec 2, 2023
* premeir test quarto

* validate yaml

* Continue avec quarto

* modification badge vscode

* passage sous forme de projet quarto

* commence à tatonner sur action

* hugo build

* update

* Ajoute des arguments au build

* ajoute l'option par défaut wrap

* modif

* Ajoute une exception pour build

* Workaround actions/checkout#760

* restructure page bundle

* rename

* retire bout problématique

* Force rendering _index.qmd

* mathjax

* gère chemin images

* ajoute image reshape

* ajoute image join

* Delete pandas_join.png

* mv file

* Ajoute le TP pandas

* quarto

* adapte le notebook

* retire fix

* file

* correction

* ajoute image

* déplace deux TP

* rename file

* rename

* typo folium

* corrige typo dans chapitre geopandas

* retour titre

* output asis

* corrige erreur

* corrige erreur

* dep

* dep

* surface

* corrige des typos

* carte arrondissements

* figures by pandas

* finalise cleaning gpd

* arrange

* Ajoute des ancres

* essaie à nouveau la construction des notebooks

* essaie à nouveau la construction des notebooks

* change artifacts dir

* change section name

* ajoute corrections au worfjlow

* ajoute corrections au worfjlow

* Qmd maps

* corrige clé

* convert matplotlib tuto

* clean qmd

* echo false

* feature engineering

* ajoute index

* Modélisation chapitre 2

* update

* tp regression

* ajoute feature selection

* clustering

* création fichier pipeline

* finit le fichier

* prb exec

* corrige erreurs

* import pandas

* no more r

* update

* ajoute image

* ajoute index

* ajoute image scikit

* typo

* duplication image

* duplication image

* les deux premiers chapittes NLP

* ajoute download

* python LDA

* error

* Exos supp

* chapitre elastic

* chapitre elastic

* rename utils

* rename

* refactorise

* introgit

* change anem

* refactorise

* refactorise

* S3

* shell

* typo

* liste TP supprimée

* update

* update wordcloud

* retour du wordcloud

* erreur nom badge

* update

* raw shortcode

* ajoute hack shortcode

* update

* en eval false

* retire import brut image

* tente un seul job pour les notebooks

* nettoie tous les shortcodes

* retire dossier notebooks

* force

* Automated changes

* script to hack names

* hack names

* add move files

* dir create

* Automated changes

* corrige typo

* Automated changes

* Automated changes

* force commit

* Automated changes

* Automated changes

* test ligne à ligne

* Automated changes

* Automated changes

* trying differently

* Automated changes

* change git add

* Automated changes

* Automated changes

* widlcard aussi là

* updae

* Automated changes

* Automated changes

* qmdise

* tuto word2vec

* les derniers TP

* retire R

* eval false pour tester

* retour

* eval false

* eval false

* retire

* Automated changes

* simplifie elastic

* master

* Automated changes

* Automated changes

* rewrite

* Automated changes

* Automated changes

* clean

* Automated changes

* resub

* Automated changes

* Automated changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenorb added a commit to EA31337/EA-Tester that referenced this issue Feb 10, 2024
kenorb added a commit to EA31337/EA-Tester that referenced this issue Feb 10, 2024
@Cirruslucent
Copy link

Syncing repository: wez/wezterm
Getting Git version info
Deleting the contents of '/__w/wezterm/wezterm'
Initializing the repository
/usr/bin/git init /__w/wezterm/wezterm
Initialized empty Git repository in /__w/wezterm/wezterm/.git/
/usr/bin/git remote add origin https://github.com/wez/wezterm
Error: fatal: unsafe repository ('/__w/wezterm/wezterm' is owned by someone else)
To add an exception for this directory, call:

git config --global --add safe.directory /__w/wezterm/wezterm

Error: The process '/usr/bin/git' failed with exit code 128

@brmonaghan
Copy link

brmonaghan commented May 1, 2024

Syncing repository: wez/wezterm Getting Git version info Deleting the contents of '/__w/wezterm/wezterm' Initializing the repository /usr/bin/git init /__w/wezterm/wezterm Initialized empty Git repository in /__w/wezterm/wezterm/.git/ /usr/bin/git remote add origin https://github.com/wez/wezterm Error: fatal: unsafe repository ('/__w/wezterm/wezterm' is owned by someone else) To add an exception for this directory, call:

git config --global --add safe.directory /__w/wezterm/wezterm

Error: The process '/usr/bin/git' failed with exit code 128

Umm, excuse me? Your answer is in the text.

daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
…e sources

git operations have started to fail with errors like

| fatal: unsafe repository ('/mnt/b/yoe/master/build/tmp/work/riscv64-yoe-linux-musl/gnulib/2018-03-07.03-r0/git' is owned by someon
e else)
| To add an exception for this directory, call:
|
|       git config --global --add safe.directory /mnt/b/yoe/master/build/tmp/work/riscv64-yoe-linux-musl/gnulib/2018-03-07.03-r0/git

This is after git has fixed a CVE in 2.35+ see [1]

[1] actions/checkout#760

Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
…e sources

git operations have started to fail with errors like

| fatal: unsafe repository ('/mnt/b/yoe/master/build/tmp/work/riscv64-yoe-linux-musl/gnulib/2018-03-07.03-r0/git' is owned by someon
e else)
| To add an exception for this directory, call:
|
|       git config --global --add safe.directory /mnt/b/yoe/master/build/tmp/work/riscv64-yoe-linux-musl/gnulib/2018-03-07.03-r0/git

This is after git has fixed a CVE in 2.35+ see [1]

[1] actions/checkout#760

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet