Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: convert baseUrl to serverApiUrl #1286

Closed
wants to merge 1 commit into from
Closed

Fix: convert baseUrl to serverApiUrl #1286

wants to merge 1 commit into from

Conversation

1newsr
Copy link
Contributor

@1newsr 1newsr commented Apr 13, 2023 •
edited
Loading

Fix octokit baseurl to convert to server apiurl.

#1246 removed the process of replacing baseUrl with serverApiUrl.

@1newsr 1newsr requested a review from a team as a code owner April 13, 2023 00:25
@1newsr 1newsr changed the title fix: convert baseUrl to apiUrl fix: convert baseUrl to serverApiUrl Apr 13, 2023
@1newsr 1newsr marked this pull request as draft April 13, 2023 00:39
@1newsr 1newsr force-pushed the fix-to-convert-baseurl-to-apiurl branch from b89e63c to a037fb9 Compare April 13, 2023 00:54
@1newsr 1newsr marked this pull request as ready for review April 13, 2023 00:54
@1newsr 1newsr force-pushed the fix-to-convert-baseurl-to-apiurl branch from a037fb9 to c31757e Compare April 13, 2023 01:00
@1newsr 1newsr changed the title fix: convert baseUrl to serverApiUrl Fix: convert baseUrl to serverApiUrl Apr 13, 2023
@1newsr 1newsr mentioned this pull request Apr 13, 2023
Merged
@fhammerl fhammerl mentioned this pull request Apr 13, 2023
Merged
@fhammerl
Copy link
Contributor

@1newsr In order to get this hotfixed asap I forked the PR and fixed the linting issues. Thanks for making this contribution!

Closed in favour of #1289

@fhammerl fhammerl closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1newsr @fhammerl