-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow proxy settings #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
force-pushed
the
users/ericsciple/m165proxy
branch
from
January 24, 2020 02:06
76cbbf5
to
d289d65
Compare
ericsciple
commented
Jan 24, 2020
ericsciple
force-pushed
the
users/ericsciple/m165proxy
branch
from
January 24, 2020 07:33
08257d3
to
2285ac1
Compare
ericsciple
commented
Jan 24, 2020
@@ -99,3 +99,42 @@ jobs: | |||
path: basic | |||
- name: Verify basic | |||
run: __test__/verify-basic.sh --archive | |||
|
|||
test-proxy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TingluoHuang i played a bit more with your idea. i think you will like this :)
ericsciple
commented
Jan 24, 2020
i5golfzaa
suggested changes
Jan 25, 2020
src/git-source-provider.ts
Outdated
repositoryPath, | ||
false | ||
) | ||
// Remove proxy and extraheader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Remove proxy and extraheader | |
// Remove proxy and extraheader |
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #139